Use view binding in VideoPlayer.#5253
Conversation
515bcaa to
064c965
Compare
Stypox
left a comment
There was a problem hiding this comment.
I tested and it works, changes also look good, thank you :-D
Maybe you could rename playerBinding into just binding, so that there is less code to read. closeOverlayBinding is ok though, since it's a specific binding.
| playbackSeekBar = (SeekBar) binding.playbackSeekBar; | ||
| qualityTextView = (TextView) binding.qualityTextView; | ||
| playbackSpeed = (TextView) binding.playbackSpeed; |
There was a problem hiding this comment.
Why did you keep these three variables?
There was a problem hiding this comment.
I was getting compilation errors as those three views were being stored as View variables for some reason.
I chose the name to keep the bindings distinguishable, but I'll rename the binding. |
064c965 to
a6db02f
Compare
a6db02f to
f2ea8cc
Compare
f2ea8cc to
fa75c79
Compare
What is it?
Description of the changes in your PR
VideoPlayerandVideoPlayerImpl.APK testing
debug.zip
Due diligence