Use @BeforeClass for ContentSettingsManagerTest.beforeClass#5204
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Dec 19, 2020
Merged
Use @BeforeClass for ContentSettingsManagerTest.beforeClass#5204Stypox merged 1 commit intoTeamNewPipe:devfrom
Stypox merged 1 commit intoTeamNewPipe:devfrom
Conversation
Member
|
The test runs correctly and code looks good, thanks and sorry for not noticing before merging #5059 ;-) |
Stypox
approved these changes
Dec 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Make initialization of
Files inContentSettingsManagerTest.ExportTestonly run once per class and not before each test. They are only read from.Fixes the following issue(s)
Due diligence