Use a notification instead of a ProgressDialog in MissionAdapter. #5142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Use_notification_instead_of_ProgressDialog
branch
from
942719c to
917f459
Compare
Stypox
approved these changes
Dec 15, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
I tested on API 19, 24 (real device), 29 (tv) and 30, everything worked. Thank you!
(unrelated to this PR: why is the checksum of a download not always the same on API 19, while it is on other APIs?)
Contributor
|
Who doesn't love them some non-deterministic checksums? |
Isira-Seneviratne
deleted the
Use_notification_instead_of_ProgressDialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
MissionAdapterusing a notification instead of aProgressDialog, as the latter has been deprecated in favor of either aProgressBaror a progress notification.APK testing
app-debug.zip
Due diligence