Rewrite ExceptionUtils methods as extension functions.#4947
Merged
Stypox merged 2 commits intoTeamNewPipe:devfrom Jan 14, 2021
Merged
Conversation
Isira-Seneviratne
force-pushed
the
Convert_ExceptionUtils_to_extensions
branch
2 times, most recently
from
f8c5d42 to
5959da1
Compare
XiangRongLin
previously approved these changes
Dec 12, 2020
Collaborator
XiangRongLin
left a comment
XiangRongLin
left a comment
There was a problem hiding this comment.
From code standpoint it looks fine to me. I did not try the apk.
@file:JvmName("ExceptionUtils") to keep the java world happy is nice and in the IDE it does get correctly indexed/linked.
Only thing i have is that the test class for Throwable is called ThrowableExtensionsTest, but that should be fine, if NewPipe wants to stick with this style.
Isira-Seneviratne
force-pushed
the
Convert_ExceptionUtils_to_extensions
branch
2 times, most recently
from
aedb0f9 to
f5beb2d
Compare
Stypox
previously approved these changes
Dec 15, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
I tested and it works. Thank you for all of the improvements :-D
but that should be fine, if NewPipe wants to stick with this style.
Yeah, I think this is ok.
Member
|
Oh, but compilation fails, could you fix this? |
Isira-Seneviratne
force-pushed
the
Convert_ExceptionUtils_to_extensions
branch
from
f5beb2d to
ff7ab1a
Compare
Member
Author
I did. |
Isira-Seneviratne
force-pushed
the
Convert_ExceptionUtils_to_extensions
branch
2 times, most recently
from
a290684 to
f2bb8b1
Compare
Isira-Seneviratne
force-pushed
the
Convert_ExceptionUtils_to_extensions
branch
from
f2bb8b1 to
8b7c597
Compare
Isira-Seneviratne
force-pushed
the
Convert_ExceptionUtils_to_extensions
branch
from
8b7c597 to
50dcf30
Compare
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 20, 2021
…nvert_ExceptionUtils_to_extensions Rewrite ExceptionUtils methods as extension functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
ExceptionUtilsmethods as extension functions for better discoverability in Kotlin.APK testing
app-debug.zip
Due diligence