Separate player gesture logic and UI #4587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
the
player
vkay94
force-pushed
the
separate-player-gesture-logic-ui
branch
from
7a5de5d to
e97f71c
Compare
Stypox
requested changes
Nov 2, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Code looks good to me, I also did some testing and everything worked as expected. Thank you!
| return true; | ||
| if (portion == DisplayPortion.LEFT) { | ||
| playerImpl.onFastRewind(); | ||
| } else if (portion == DisplayPortion.RIGHT) { |
Member
There was a problem hiding this comment.
Could you add here else if (portion == DisplayPortion.MIDDLE) { playerImpl.onPlayPause(); }, so that a double tap in the middle changes the playing state, as it did before #2907? Or will you do this in a future PR?
Contributor
Author
There was a problem hiding this comment.
Oh, I missed this middle gesture somehow., my bad. I'll add it again (or if you'd like to you can do it since you're authorized) :')
Member
There was a problem hiding this comment.
Ok, I'm gonna do it and then merge
Stypox
force-pushed
the
separate-player-gesture-logic-ui
branch
from
e97f71c to
347566c
Compare
Stypox
approved these changes
Nov 2, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR separates the logic behind the player gestures (for example popup position observation) and the UI (for example show/hide controls and adjusting the brightness during scrolling) This way it is more readable.
BasePlayerGestureListenerwhich handles the logic and provides abstract methods for listeningPlayerGestureListenercontains only visual codeDisplayPortionenum class (LEFT,MIDDLE,RIGHTfor double tap,LEFT_HALF,RIGHT_HALFfor scrolling)APK testing
app-debug-0.20.2-fix.zip
Due diligence