Use ContextCompat methods.

[Isira-Seneviratne]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Use ContextCompat's getSystemService and startForegroundService methods.

Testing apk

debug.zip

Agreement

• I carefully read the contribution guidelines and agree to them.

[Redirion]

in App.java the method initNotificationChannel can be made private and the method setUpUpdateNotificationChannel could be merged into it. You could rename initNotificationChannel to initNotificationChannels and use the method createNotificationChannels. This way we can skip one call to getSystemService

The variables id, name and description can have their final modifier removed to be reused for the appUpdateChannel

can you add these changes to your PR?

[Isira-Seneviratne]

in App.java the method initNotificationChannel can be made private and the method setUpUpdateNotificationChannel could be merged into it. You could rename initNotificationChannel to initNotificationChannels and use the method createNotificationChannels. This way we can skip one call to getSystemService

The variables id, name and description can have their final modifier removed to be reused for the appUpdateChannel

can you add these changes to your PR?

Sure.

[Redirion]

Thank you for the fast changes, but please use createNotificationChannels to provide both Channels at once.

See here why it is useful: https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/app/NotificationManager.java#819

[Isira-Seneviratne]

I fixed a merge conflict.

[Stypox]

Almost there, thank you!

[Stypox]

Code looks good, thank you! Could you provide a test apk? After some testing I'll merge

[Isira-Seneviratne]

Code looks good, thank you! Could you provide a test apk? After some testing I'll merge

Sure.

[Isira-Seneviratne]

I uploaded a test APK in debug.zip.

[Stypox]

I tested every activity you changed on API 19 and everything works correctly. Thank you!