Drop LoadController to just rely on DefaultLoadControl of ExoPlayer #4251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
In the future I would prefer to rely on Google to find reasonable values for buffers as they do in their DefaultLoadControl.
The last change to buffer values NewPipe did was 2,5 Years ago with this commit: b466836
The commit aimed to speed up start of initial playback.
However as issues like #3251 show, on an unstable connection, this can lead to buffer under-runs.
On the other hand I don't think that users with a high speed connection will notice this change as the high speed connection will fill the 5 times longer start buffer duration quick anyway. This is also the most significant change by dropping NewPipe's LoadController. The minimum buffer is increased from 500ms to 2500ms.
Fixes the following issue(s)
Fixes #3251
Testing apk
https://github.com/Redirion/NewPipe/releases/tag/removeloadcontroller
Agreement