Skip to content

Conversation

@AliJavanJ1
Copy link

@AliJavanJ1 AliJavanJ1 commented Aug 6, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

saves the shuffle mode in shared preferences and retrieves it after initiating player.
the shared preferences resets in main activities onDestroy method

Fixes the following issue(s)

Testing apk

debug.zip

Agreement

@opusforlife2
Copy link
Collaborator

Upload a test apk in the OP after you're done making changes, dudeman.

@opusforlife2 opusforlife2 added the player Issues related to any player (main, popup and background) label Aug 7, 2020
@wb9688
Copy link
Contributor

wb9688 commented Aug 16, 2020

@opusforlife2: Not really needed for such small changes.

@AliJavanJ1: Could you please rebase on dev and fixup your commits? Also, why would we want to disable shuffling as soon as the MainActivity gets destroyed?

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from the MainActivity change. Could you provide an explanation @AliJavanJ1 ? Otherwise I will revert that change and then merge, since the other changes look good. Thank you ;-)

@Stypox Stypox self-assigned this Sep 2, 2020
@TobiGr TobiGr force-pushed the dev branch 2 times, most recently from 679bc75 to 2aeccc0 Compare March 16, 2021 08:24
@litetex litetex marked this pull request as draft October 1, 2021 17:26
@litetex
Copy link
Member

litetex commented Oct 1, 2021

Closing this for now:

  • no progress
  • no GitHub actions build
  • merge conflicts
  • no feedback from author

Feel free to reopen it when there is progress again.

@litetex litetex closed this Oct 1, 2021
@litetex litetex mentioned this pull request Oct 10, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

player Issues related to any player (main, popup and background)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remember player states like Shuffle, Repeat, etc.

5 participants