Conversation
ckb - Central Kurdish jv - Javanese kab - Kabyle
| <item>@string/systems_language</item> | ||
| <item>Basa Acèh</item> | ||
| <item>العربية</item> | ||
| <item>العربية (ليبيا)</item> |
There was a problem hiding this comment.
Why the country name here and not just the code? I think that's better though, but then you should change it for the other languages as well to remain consistent. And why the () before but for the languages a few lines further after?
There was a problem hiding this comment.
I think it is good. No country code, because this would be in Latin letters and we'd have to deal with RTL and LTR in one line. And the () before the language name, because that's RTL, so still at the end of the line
There was a problem hiding this comment.
Oh, I incorrectly assumed Bengali was RTL as well, but apparently it's just LTR. My other point still stands, i.e. changing e.g. "Nederlands (BE)" to "Nederlands (België)" for more consistency.
There was a problem hiding this comment.
Oh. I didn't see you reply. I'd say we can put that on our list for the next release, but not this one.
3 participants
What is it?
Description of the changes in your PR
add languages
Fixes the following issue(s)
Testing apk
i can't upload it…
Agreement