Skip to content

bbc sounds support#3857

Closed
yausername wants to merge 6 commits intoTeamNewPipe:devfrom
yausername:bbc_sounds
Closed

bbc sounds support#3857
yausername wants to merge 6 commits intoTeamNewPipe:devfrom
yausername:bbc_sounds

Conversation

@yausername
Copy link
Contributor

@yausername yausername commented Jul 7, 2020 •
edited
Loading

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • bbc sounds support

I am not totally sure about the svg decoder thing. It works though.

Relies on the following changes

Testing apk

app-debug.apk.zip

Agreement

@mauriciocolli
Add support for different types of stream delivery
9dde296 
For example, some streams have a direct link to them, and others use
something like DASH or a HLS playlist. This adds support for them.

The downloader doesn't support them yet, so when downloading these
types of streams, they will be hidden.
@mauriciocolli
Call the correct dismiss method for the DownloadDialog
d0449ab
@mauriciocolli
Temporary fix for trying to download an item with no supported streams
9970d8d
@mauriciocolli
[SoundCloud] Lower the expiration time
34a84bb 
Streams delivered by SoundCloud are not valid for very long, so a lower
expiration time is needed.
@mauriciocolli
TEMP: Extractor Version
efbf79f
@TobiGr
Copy link
Contributor

TobiGr commented Jul 7, 2020

@yausername Thank you. I got in touch with the user requesting the feature and asked him to test your changes.

@yausername
Copy link
Contributor Author

yausername commented Jul 7, 2020

@yausername Thank you. I got in touch with the user requesting the feature and asked him to test your changes.

Sure, thanks!

@ghost

This comment has been minimized.

Sign in to view
@wb9688
Copy link
Contributor

wb9688 commented Jul 13, 2020

@ingingin: No: https://www.bbc.co.uk/sounds

@MainTomato
Copy link

MainTomato commented Nov 26, 2020

Love this feature, been using It at work. I hope this gets added to the main release. 👍

@yausername
Copy link
Contributor Author

yausername commented Nov 26, 2020

@MainTomato I'm glad you like it. :)

@TobiGr
Copy link
Contributor

TobiGr commented Nov 26, 2020

I'll look at the extractor once I finished my review of TeamNewPipe/NewPipeExtractor#232

@MainTomato
Copy link

MainTomato commented Dec 4, 2020

I can see some improvements that can be made.

  1. It would be nice to be able to view all the categories on this page In the app - https://www.bbc.co.uk/sounds/categories
  2. On the homepage of https://www.bbc.co.uk/sounds, there's tons of featured content like "Unmissable Sounds". Adding a featured tab to the app would be nice as well. As of right now I think It's hard to view all the content sounds has to offer unless you search for It.

@yoshimo
Copy link

yoshimo commented Feb 10, 2021

Does this cover the display of the currently played song which is available for a few programmes?

@TobiGr TobiGr force-pushed the dev branch 2 times, most recently from 679bc75 to 2aeccc0 Compare March 16, 2021 08:24
@litetex litetex marked this pull request as draft October 1, 2021 17:19
@litetex
Copy link
Member

litetex commented Oct 1, 2021

Closing this for now:

  • replies on closed PRs
  • no progress
  • no GitHub actions build
  • merge conflicts

Feel free to reopen it when there is progress again.

@litetex litetex closed this Oct 1, 2021
@litetex litetex mentioned this pull request Oct 10, 2021
Closed
2 tasks
@ShareASmile
Copy link
Collaborator

ShareASmile commented Nov 15, 2022

i would like to bump this one, so that it is picked up again.

I can see some improvements that can be made.

Yes, I woluld request among other improvements to include Asian feed also
https://www.bbc.co.uk/sounds/play/live:bbc_asian_network

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Nov 16, 2022

Don't comment on a closed PR. Comment in the open issue.

@ShareASmile ShareASmile mentioned this pull request Dec 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@yausername @TobiGr @wb9688 @MainTomato @yoshimo @litetex @ShareASmile @opusforlife2 @mauriciocolli