Move Stored(File|Directory)Helper into NewPipe #3781
Closed
wb9688 wants to merge 2 commits intoTeamNewPipe:devfrom
wb9688:refactor-storedhelpers
Closed
Move Stored(File|Directory)Helper into NewPipe #3781wb9688 wants to merge 2 commits intoTeamNewPipe:devfrom wb9688:refactor-storedhelpers
wb9688 wants to merge 2 commits intoTeamNewPipe:devfrom
wb9688:refactor-storedhelpers
Conversation
Stypox
requested changes
Jul 29, 2020
app/src/main/java/org/schabi/newpipe/streams/io/StoredDirectoryHelper.java
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/streams/io/StoredDirectoryHelper.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/schabi/newpipe/streams/io/StoredDirectoryHelper.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This moves
StoredFileHelperandStoredDirectoryHelperinto NewPipe, while fixing a lot of code style issues.Relies on the following changes
#3777
Agreement