Fix search crash: adapter array index out of bounds#3759
Merged
wb9688 merged 1 commit intoTeamNewPipe:devfrom Jun 11, 2020
Merged
Fix search crash: adapter array index out of bounds#3759wb9688 merged 1 commit intoTeamNewPipe:devfrom
wb9688 merged 1 commit intoTeamNewPipe:devfrom
Conversation
|
Sure, I'll try to report back in the next hour or so. I was not able to run the APK on my Nvidia shield. I received a "There was a problem parsing the package" error trying to install it. |
|
Nope. I wrote on the original issue. It did not work. I have like 5 phones running newpipe latest and only two have this problem. I have the leaks canary app. How to get data from it? |
Member
Author
|
I'm closing this since it apparently does not fix anything but only moves the crash elsewhere @test2a LeakCanary can provide leak information if enabled via "Settings → Debug", but in this case that information wouldn't be useful |
Member
Author
|
Reopening since this fixes #3575. I just tested and the fix works, even though a strange (unpreventable) behaviour arises when swiping too fast. |
wb9688
approved these changes
Jun 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
I don't know the cause of the IndexOutOfBounds exception, it could have something to do with the adapter not having finished to update itself after the last call to
notifyDataSetChanged(). Anyway, a simple check should fix it.Fixes the following issue(s)
Fixes #3575
Testing apk
@ltomes @test2a could you test this apk and see if it fixes the issue?
app-debug.zip
Agreement