Update LICENSE #3699

BeatRoy · 2020-05-31T10:31:30Z

Filled in placeholders to make it a valid license.

What is it?

Bug fix (user facing)
Feature (user facing)
Code base improvement (dev facing)
Meta improvement to the project (dev facing)

Description of the changes in your PR

Filled in placeholders to make it a valid license.

Fixes the following issue(s)

Not filled in placeholders on the GNUv3 License

Agreement

I carefully read the contribution guidelines and agree to them.

Filled in placeholder to make it a valid license. Before <program> Copyright (C) <year> <name of author> Copyright (C) <year> <name of author> After NewPipe Copyright (C) 2020 TeamNewPipe Copyright (C) 2020 TeamNewPipe

ghost

Looks good to me ¯_(ツ)_/¯ Like how you changed it to HTTPS :D

BeatRoy

"<one line to give the program's name and a brief idea of what it does.>" on line 634 needs to be replaced with a short rule that explains what the program does.

BeatRoy · 2020-05-31T18:37:27Z

LICENSE

@@ -632,7 +632,7 @@ state the exclusion of warranty; and each file should have at least
 the "copyright" line and a pointer to where the full notice is found.

    <one line to give the program's name and a brief idea of what it does.>


maybe this needs to be changed to something else also.

I think the label shown on F-Droid, i.e. "A free lightweight YouTube frontend for Android", would be suitable

Thanks @Stypox I changed it to "NewPipe a free lightweight YouTube frontend for Android"

NewPipe ist not only about YouTube. It's what we started with.

@TobiGr What should I change it to?

Ah yes. The author of the issue should have demanded or taken action at some point...

As a user, the most important things I would notice in the logo are FOSS, Youtube and other services, and Android.

The lightweight doesn't matter. Nor does front-end.

How about "Newpipe - A FOSS client for Youtube and other streaming services"?

On GitHub it is "A libre lightweight streaming front-end for Android"

Libre is a disambiguation between free (price) and free (as in freedom) and libre means free (as in freedom). You should read this to know more about libre software.

Sure. "Newpipe - A libre client for YouTube and other streaming services", then.

So it needs to be changed to "A libre lightweight streaming front-end for Android" @B0pol @TobiGr?

changed placeholder "<one line to give the program's name and a brief idea of what it does.>" to "NewPipe a free lightweight YouTube frontend for Android"

TheAssassin

I would not change the license at all. There is no need to do so, I don't think it's a good idea to deviate from the upstream text.

LICENSE

TheAssassin

You know what? Please ignore my previous review. I think you have a valid point, at least with the first change of the description. It seems you're right about other hosting platforms.

However, I think @B0pol and @TobiGr need to propose a proper text we should include there. Ideally, this'll be the same slogan we'll later apply in all the other places.

BeatRoy · 2020-05-31T23:15:54Z

Sounds great, when @B0pol and @TobiGr have a chosen a slogan I will change it.

B0pol · 2020-06-11T12:25:23Z

LICENSE

-    <one line to give the program's name and a brief idea of what it does.>
-    Copyright (C) <year>  <name of author>
+    NewPipe a free lightweight YouTube frontend for Android
+    Copyright (C) 2020 TeamNewPipe


We are Team NewPipe, not TeamNewPipe. The repo url is TeamNewPipe but if you go it, you'll see Team NewPipe as name.

B0pol · 2020-06-11T12:26:31Z

LICENSE


    You should have received a copy of the GNU General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+    along with this program.  If not, see <https://www.gnu.org/licenses/>.


Update all copyright notices with HTTPS links, as mentioned in the license here (with this change, and according to the newest version on gnu.org), the copyright notices in files should have HTTPS links.

I think the copyright notice should be

/* * Copyright (C) <year-file-created> - <year, up to date> Team NewPipe <[email protected]> * <file>.<extension> is part of NewPipe. * * NewPipe is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * NewPipe is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with NewPipe. If not, see <https://www.gnu.org/licenses/>. */

change NewPipe by NewPipe Extractor for NewPipe Extractor.

And move this right after package declaration, before imports

B0pol

Wrong button. See my review above

B0pol · 2020-06-22T17:56:38Z

I made some tests and I found why GitHub don't recognise LICENSE as GPLv3
In fact it recognise copyright, which is GPL v3 but not the original text
If we remove copyright it will be ok
and it will also work if we change placeholder with NewPipe, Team NewPipe and 2020

BeatRoy · 2020-07-02T10:38:19Z

do i need to change anything or is it now ready to merge?

B0pol · 2020-07-02T11:13:16Z

You need to change few things. Read the review above (I missclicked on approve)

litetex · 2021-10-01T17:14:54Z

No progress since a year and no feedback from the author.

Closing this PR for now. Feel free to reopen it when there is progress again.

Update LICENSE

63e21d7

Filled in placeholder to make it a valid license. Before <program> Copyright (C) <year> <name of author> Copyright (C) <year> <name of author> After NewPipe Copyright (C) 2020 TeamNewPipe Copyright (C) 2020 TeamNewPipe

ghost previously approved these changes May 31, 2020

View reviewed changes

BeatRoy commented May 31, 2020

View reviewed changes

Update LICENSE

a212324

changed placeholder "<one line to give the program's name and a brief idea of what it does.>" to "NewPipe a free lightweight YouTube frontend for Android"

BeatRoy dismissed ghost ’s stale review via a212324 May 31, 2020 20:31

TobiGr requested a review from TheAssassin May 31, 2020 22:11

TheAssassin requested changes May 31, 2020

View reviewed changes

LICENSE Show resolved Hide resolved

LICENSE Show resolved Hide resolved

TheAssassin requested changes May 31, 2020

View reviewed changes

B0pol approved these changes Jun 11, 2020

View reviewed changes

B0pol requested changes Jun 11, 2020

View reviewed changes

B0pol mentioned this pull request Jun 12, 2020

Expandable player with unified UI #2907

Merged

TobiGr force-pushed the dev branch 2 times, most recently from 679bc75 to 2aeccc0 Compare March 16, 2021 08:24

litetex marked this pull request as draft October 1, 2021 17:14

litetex closed this Oct 1, 2021

litetex mentioned this pull request Oct 10, 2021

Add CODEOWNERS file #7216

Closed

2 tasks

		@@ -632,7 +632,7 @@ state the exclusion of warranty; and each file should have at least
		the "copyright" line and a pointer to where the full notice is found.

		<one line to give the program's name and a brief idea of what it does.>

Uh oh!

Update LICENSE #3699

Update LICENSE #3699

Uh oh!

Conversation

BeatRoy commented May 31, 2020

What is it?

Description of the changes in your PR

Fixes the following issue(s)

Agreement

Uh oh!

ghost left a comment • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BeatRoy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BeatRoy Jun 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheAssassin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TheAssassin left a comment

Choose a reason for hiding this comment

Uh oh!

BeatRoy commented May 31, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

B0pol left a comment

Choose a reason for hiding this comment

Uh oh!

B0pol commented Jun 22, 2020

Uh oh!

BeatRoy commented Jul 2, 2020

Uh oh!

B0pol commented Jul 2, 2020

Uh oh!

litetex commented Oct 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ghost left a comment •

edited by ghost

Loading

BeatRoy left a comment •

edited

Loading

BeatRoy Jun 6, 2020 •

edited

Loading