Skip to content

Conversation

@spk
Copy link
Contributor

@spk spk commented May 30, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This allow NewPipe to remember the directories for export and import, so its easier and faster to restore and save to the desired directory. When the directory is deleted this fallback to the standard external storage directory.

Testing apk

app-debug.zip

Agreement

@wb9688
Copy link
Contributor

wb9688 commented May 30, 2020

Not sure whether we want this, as this behavior is only possible with the No-Nonsense File Picker, and we want to use SAF here as well soon, though not always:

  • Android 4: No-Nonsense File Picker only
  • Android 5-9: SAF by default, No-Nonsense File Picker as option
  • Android 10: SAF only

@spk
Copy link
Contributor Author

spk commented Jun 2, 2020

Not sure whether we want this, as this behavior is only possible with the No-Nonsense File Picker, and we want to use SAF here as well soon, though not always:

* Android 4: No-Nonsense File Picker only

* Android 5-9: SAF by default, No-Nonsense File Picker as option

* Android 10: SAF only

Ok I did not know that but I see that the autobackup PR #3157 will help with this issue so I'm closing it

@spk spk closed this Jun 2, 2020
@spk spk deleted the remember-import-export-directory branch June 2, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants