Skip to content

feat(add-rtl-layout-support): drawer, tabs, list items & about #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Royosef wants to merge 3 commits into from
Closed

feat(add-rtl-layout-support): drawer, tabs, list items & about #3488

Royosef wants to merge 3 commits into from

Conversation

@Royosef
Copy link
Contributor

@Royosef Royosef commented Apr 25, 2020 •
edited by B0pol
Loading

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

feat(add-rtl-layout-support): drawer, tabs, list items & about

  • supportsRtl="true"
  • replace Left/ Right properties with Start/ End
  • tabs:
    • layoutDirection="ltr" for
    • reverse items for RTL in PagerAdapter
  • properties for force right in RTL:
    • textAlignment="viewStart"
    • textDirection="anyRtl"

image

image

image

image

image

image

image

fixes #3882

Testing apk

NewPipe_AddRtlLayoutSupport-debug.zip

Agreement

@Royosef
feat(add-rtl-layout-support): drawer, tabs, list items & about
948db2a 
* supportsRtl="true"
* replace Left/ Right properties with Start/ End
* tabs:
	* layoutDirection="ltr" for <TabsLayout>
	* reverse items for RTL in PagerAdapter
* properties for force right in RTL:
	* textAlignment="viewStart"
	* textDirection="anyRtl"
@TobiGr TobiGr added the localisation / translation Everything that has to do with translations or Weblate label Apr 25, 2020
@TobiGr TobiGr added this to the 0.19.4 milestone Apr 25, 2020
B0pol
B0pol requested changes Apr 25, 2020
View reviewed changes
@Royosef
fix(PR-review): export common functions as utils
9c70368 
* export getLayoutPosition() & isRTL() to LocalizeLayoutUtil class
@Royosef Royosef force-pushed the AddRtlLayoutSupport branch from dcc3142 to 9c70368 Compare April 26, 2020 18:06
@TobiGr TobiGr requested a review from B0pol May 3, 2020 12:34
B0pol
B0pol requested changes May 13, 2020
View reviewed changes
Copy link
Member

@B0pol B0pol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd merge LocalizeLayoutUtils (used to know if the device should be RTL and one method around that) and AndroidTvUtils to DeviceUtils. What do you think about that @Stypox @wb9688?

GUI bugs:
(Screenshots using urdu, the language using an arabic alphabet at the bottom of the list, that's why there are some english words, it's not the case with arabic, which is better translated).

  • The space between "All" feed & new is too large:

  • In crash report, in info about device, things are mixed between right and left:

    Here is an easily reproducible bug so that you can test: share this PeerTube playlist to NewPipe.

@B0pol B0pol added the GUI Issue is related to the graphical user interface label May 13, 2020
@B0pol B0pol self-assigned this May 13, 2020
@Royosef
fix(report-error&feed-group-carousel)
28b0b12 
* fix info section direction in report error page
* fix margin at the feed group carousel in subscriptions page
@TobiGr
Copy link
Contributor

TobiGr commented May 16, 2020

I'd merge LocalizeLayoutUtils (used to know if the device should be RTL and one method around that) and AndroidTvUtils to DeviceUtils.

@B0pol Sounds good to me

@Stypox Stypox modified the milestones: 0.19.4, 0.19.5 May 28, 2020
@TobiGr
Copy link
Contributor

TobiGr commented Jun 26, 2020

@Royosef What's the state of this PR? Are you going to merge LocalizeLayoutUtils and AndroidTvUtils into DeviceUtils?

@wb9688
Copy link
Contributor

wb9688 commented Jun 27, 2020

I would move this to v0.20.0 as well

@TobiGr TobiGr modified the milestones: 0.19.6, 0.20.0 Jun 27, 2020
@wb9688 wb9688 mentioned this pull request Jul 14, 2020
Open
@wb9688 wb9688 modified the milestones: 0.20.0, 0.20.1 Jul 29, 2020
@blackbox87 blackbox87 mentioned this pull request Aug 26, 2020
Merged
5 tasks
@Stypox Stypox modified the milestones: 0.20.1, 0.20.2 Oct 4, 2020
@heberjeur
Copy link

heberjeur commented Dec 26, 2020

@B0pol @Stypox when this feature will be added?

@Stypox
Copy link
Member

Stypox commented Jan 15, 2021

@heberjeur when @Royosef implements the requested changes and all bugs are fixed

@TobiGr TobiGr force-pushed the dev branch 2 times, most recently from 679bc75 to 2aeccc0 Compare March 16, 2021 08:24
@litetex litetex marked this pull request as draft October 1, 2021 17:05
@litetex
Copy link
Member

litetex commented Oct 1, 2021 •
edited
Loading

No progress since a year, no GitHub actions build and a lot of merge conflicts.

Closing this for now. Feel free to reopen it when there is progress again.

@litetex litetex closed this Oct 1, 2021
@litetex litetex mentioned this pull request Oct 10, 2021
Closed
2 tasks
@triallax triallax mentioned this pull request Jan 13, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B0pol B0pol B0pol requested changes

Assignees

@B0pol B0pol

Labels

GUI Issue is related to the graphical user interface localisation / translation Everything that has to do with translations or Weblate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RTL UI for rtl languages such as ckb,ku,ar,urdu...etc

7 participants

@Royosef @TobiGr @wb9688 @heberjeur @Stypox @litetex @B0pol