Fix repeated exceptions in Bookmarked Playlists #3345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitosagi
changed the title
Contributor
|
You still haven't fixed all coding style issues. Also, we prefer rebasing instead of having a lot of merge commits. |
Contributor
|
Thank you for the fix. Please squash your commits |
mitosagi
force-pushed
the
error-with-bookmarks
branch
from
067a054 to
4491b66
Compare
Contributor
|
The code itself is OK now. @mauriciocolli: Shouldn't it be impossible for playlist names to be null? If so, could you write a migration instead? |
TobiGr
approved these changes
Apr 19, 2020
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Thank you 👍
I'll merge this for now to fix the crash in the next version. We can revert that cahnge later once we have a migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Long description of the changes in your PR
This is a fix for #3261 (App loops in null pointer with bookmarks exception).
A fix for a bug that prevented the Bookmarked Playlists screen from being displayed because the playlist name had changed to null for some reason.
When Bookmarked Playlists is displayed, sorting is done against the playlist names. This PR prevents crashes by allowing you to sort playlist names that contain a null.
The fundamental solution is to prevent null in playlist names, but I think this fix is necessary to open a database that is already in an unopenable state.
Fixes the following issue(s)
Testing apk
apk: errorwithbookmarks.zip
database: NewPipeData-Test.zip
Steps to reproduce the behavior:
Agreement