Skip to content

Conversation

@therealrambo
Copy link

removed redundant line on the f-droid inclusion policy.

removed redundant line on the f-droid inclusion policy
@gkeegan
Copy link
Contributor

gkeegan commented Feb 4, 2020

I think both lines there are important, and you just removed a valuable link for people to discover what is meant.

@therealrambo
Copy link
Author

there is no valuable link removed. both lines link to the same page and say "use this guideline with your code." there is nothing of importance added on the second one.

@gkeegan
Copy link
Contributor

gkeegan commented Feb 4, 2020

Oh I see I thought you meant a different line is the copy.

Perhaps remove the line "stick to the guidelines" and keep the one you are removing?

@therealrambo
Copy link
Author

maybe, it does not really matter. the second one has some grammar issues though.

about submission, or clearly state that in the description of your PR.
* Respond yourselves if someone requests changes or otherwise raises issues about your PRs.
* Check if your contributions align with the [fdroid inclusion guidelines](https://f-droid.org/en/docs/Inclusion_Policy/).
* Check if your submission can be build with the current fdroid build server setup.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be F-Droid, not fdroid

@therealrambo
Copy link
Author

I'm sorry if I didn't make this clear, the sentence I removed is almost exactly like an earlier sentence in this section; that sentence is "Stick to F-Droid contribution guidelines." They also both have the same link to the same website.

@Stypox
Copy link
Member

Stypox commented Mar 5, 2020

@therealrambo while you are at it, could you please change all occourences of "fdroid" with "F-Droid"? Sorry for the late reply

@B0pol B0pol mentioned this pull request Apr 4, 2020
5 tasks
@TobiGr TobiGr closed this in #3356 Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants