Sleep timer #2892

javedh-dev · 2019-12-25T18:36:11Z

Hi all,

I have updated the target SDK version to 29 and a few other dependency versions to its latest.
I have also added a sleep timer similar to Spotify in background player.

Please review the changes and merge.

I carefully read the contribution guidelines and agree to them.

TobiGr

Thank you for your contribution! The sleep timer is a frequently requested feature. That's why, I'd like to ship it with a good UI and implementation. To achieve this, I'd like to discuss some changes.

Clean UI and UX

Users should be able to select the exact time when to put NP to sleep. This means, there should be no predefined values, but a number picker. When a timer is running and the timer button was pressed, the remaining time should be displayed.
At all: Do you think a minute picker is enough or do we also need to offer a hours/seconds picker?

Stop timer

Please add an option to stop the timer. Every time bomb has a breaker, so should our sleep timer :)
To achieve this, please make sure to only create one timer and modify it when a time is selected or a stop button was pressed. Otherwise we might end up with multiple timers when a user wants to modify the remaining time. This could cause unexpected results e.g. when one tries to extend the remaining time but instead a new timer is created having no affect because the player would be stopped earlier by the old timer.

Clean code

Make all used strings translatable using the strings.xml file. Please ensure that your changes run on all supported Android versions. KitKat (Android 4.4) handles vector drawables differently than later versions. Using them can result in a crash on those devices,

Caution when updating dependencies, Gradle etc.

Please update dependencies in a separate PR when they do not directly affect your changes. Dependency updates need to be tested and verified cautiously, because they can brake functionality. Moreover, you bumped the target SDK, although there are some problems with level 29 api devices which have not been resolved. The build fails, too, because you did not update the specs for Travis in .travis.yml simultaneously. .

javedh-dev · 2019-12-26T03:22:56Z

Thanks Tobias, really appreciate your quick reply. I'll make sure these changes are implemented and I'll also look into the dependency upgrades. I'll get back to you soon.

This reverts commit a00be6e

This reverts commit fa20e99

javedh-dev · 2019-12-28T08:37:37Z

Hi,
Can you please review these new changes and let me know if they are fine.

TobiGr

I am sorry for the delay.

app/src/main/java/org/schabi/newpipe/player/BackgroundPlayer.java

app/src/main/res/values/strings.xml

app/src/main/java/org/schabi/newpipe/player/BackgroundPlayer.java

app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java

Co-Authored-By: Tobias Groza <[email protected]>

javedh-dev · 2020-02-02T10:16:39Z

Hi @TobiGr ,
Thanks for replying and reviewing. I have submitted the requested changes. Can you please verify once.
Thanks

TobiGr

Thanks for the quick reply!

app/src/main/java/org/schabi/newpipe/player/BackgroundPlayer.java

app/src/main/res/values/strings.xml

app/src/main/java/org/schabi/newpipe/player/BasePlayer.java

app/src/main/java/org/schabi/newpipe/player/ServicePlayerActivity.java

app/src/main/java/org/schabi/newpipe/player/BackgroundPlayer.java

app/src/main/java/org/schabi/newpipe/player/BasePlayer.java

app/src/main/java/org/schabi/newpipe/player/BackgroundPlayer.java

javedh-dev · 2020-02-23T10:01:44Z

@javed-hussain can you give NewPipe Sleep Timer apk based on latest changes?

Hi @gillhash,

I can provide you the APK with latest changes merged. I have added one more change recently -
Automatic conversion of m4a audio format to mp3 on youtube audio download. That might have increased the size of apk a bit due to adding external library.
Please let me know if that change is fine with you. I am using the same build but haven't tested on all devices but working perfectly fine for me.

Thanks
Javed Hussain

ShareASmile · 2020-02-23T10:14:30Z

@javed-hussain thanks for responding.

Yes, that would be great. Please upload the apk. #3043 PR (my fav) has been merged with dev branch today. Would that be included or your apk is built on latest 0.18.4

javedh-dev · 2020-02-23T10:17:53Z

@javed-hussain thanks for responding.

Yes, that would be great. Please upload the apk. #3043 PR (my fav) has been merged with dev branch today. Would that be included or your apk is built on latest 0.18.4

I'll merge the build with the latest dev and then generate the apk. So that should be included.

Thanks.

Stypox · 2020-02-23T10:56:44Z

Please remove mp3 conversion from this PR, it is completely unrelated to the sleep timer.
Also, as discussed in #507, we currently don't want to implement conversion (go discuss there if new alternatives to ffmpeg have arisen)

ShareASmile · 2020-02-23T10:57:52Z

@javed-hussain
On a rethought: you can give apk you use based on latest 0.18.4 changes. Because debug apk will be more big in size & i can do without "unhook speed fix for the time being.

i m using Samsung J2 Pro Android 6.0.1.
Many Thanks, Love your work ❤

javedh-dev · 2020-02-23T11:06:23Z

Please remove mp3 conversion from this PR, it is completely unrelated to the sleep timer.
Also, as discussed in #507, we currently don't want to implement conversion (go discuss there if new alternatives to ffmpeg have arisen)

Sure @Stypox . That changes are not related to this PR. They are for my personal use. I wanted that change so I generated the build with that. I'll remove those changes at the time of merging with main branch

javedh-dev · 2020-02-23T11:10:53Z

@javed-hussain
On a rethought: you can give apk you use based on latest 0.18.4 changes. Because debug apk will be more big in size & i can do without "unhook speed fix for the time being.

i m using Samsung J2 Pro Android 6.0.1.
Many Thanks, Love your work ❤
Hi @gillhash,

Thanks for the appreciation. If you want you can download the build from below link and This is a release build not a debug one.
(https://github.com/javed-hussain/NewPipe/releases/tag/v0.18.4)

Thanks
Javed

ShareASmile · 2020-02-23T12:02:59Z

@javed-hussain
Given apk is not installing on my Samsung SM-J210F Galaxy J2Pro Android 6.0.1. Api level 23.

javedh-dev · 2020-02-23T16:26:58Z

@gillhash did you try uninstalling the previous version.

ShareASmile · 2020-02-27T07:41:26Z

Hi @javed-hussain would you Please remove mp3 conversion from this PR?

..as testing phase is starting of PRs in this Milestone.

javedh-dev · 2020-02-27T11:18:47Z

Hi @javed-hussain would you Please remove mp3 conversion from this PR?

..as testing phase is starting of PRs in this Milestone.

Sure @gillhash I'll do that.

panther7 · 2020-05-16T22:22:22Z

+1 for sleep timer, thanks

RickyM7 · 2020-12-07T03:21:03Z

Any progress on this feature? This is something really useful and would be amazing if it were added to NewPipe.

javedh-dev · 2020-12-07T03:31:53Z

Any progress on this feature? This is something really useful and would be amazing if it were added to NewPipe.

Hi @RickyM7 ,
Got stuck with some other work. Will try to merge with latest changes and update this PR.

RickyM7 · 2020-12-07T03:56:40Z

@javedh-dev Thank you.

metzger100 · 2021-03-30T00:18:33Z

Any progress on this feature? This is something really useful and would be amazing if it were added to NewPipe.

Hi @RickyM7 ,
Got stuck with some other work. Will try to merge with latest changes and update this PR.

That would be great yes. The Sleep timer is a feature I am still waiting for. Would be awesome if you could add it.

litetex · 2021-10-01T17:50:03Z

Closing this for now:

no progress since >9 months
extremely old code-base (2 years - >4k commits) it's nearly impossible that all changes now work correctly even after rebasing
no GitHub actions build
massive merge conflicts
massive changes requested

Feel free to reopen it when there is progress again.

tsiflimagas · 2021-10-01T18:53:01Z

This is such a useful feature to have! I hope it'll eventually be picked up again.

litetex · 2021-10-01T18:58:45Z

Was closed here: #2830

tsiflimagas · 2021-10-01T19:09:57Z

Was closed here: #2830

I checked the app linked there and is a very nice solution, thanks!

Javed Hussain added 2 commits December 25, 2019 23:58

Gradle version upgrade

fa20e99

Sleep Timer

a00be6e

TobiGr requested changes Dec 26, 2019

View reviewed changes

TobiGr added feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) labels Dec 26, 2019

Javed Hussain added 4 commits December 28, 2019 13:20

Revert "Sleep Timer"

4a7ee54

This reverts commit a00be6e

Revert "Gradle version upgrade"

145762c

This reverts commit fa20e99

New sleep timer with TimePicker

f25c871

Merge branch 'dev' into dev

7826505

javedh-dev requested a review from TobiGr December 28, 2019 08:38

Merge branch 'dev' into dev

d0e183a

TobiGr added this to the 0.18.2 milestone Jan 13, 2020

TobiGr changed the title ~~Updated some dependencies and Sleep timer.~~ Sleep timer Jan 22, 2020

TobiGr reviewed Feb 1, 2020

View reviewed changes

Javed Hussain and others added 4 commits February 2, 2020 15:09

Merge branch 'dev' into dev

c030231

Log cleaned.

47eb883

Co-Authored-By: Tobias Groza <[email protected]>

Performed Request Changes in - Sleep timer #2892

372106d

Performed Request Changes in - Sleep timer #2892

94dcdc4

javedh-dev requested a review from TobiGr February 2, 2020 10:15

Reformatted the string

532608b

TobiGr reviewed Feb 2, 2020

View reviewed changes

app/src/main/java/org/schabi/newpipe/player/BackgroundPlayer.java Show resolved Hide resolved

app/src/main/res/values/strings.xml Show resolved Hide resolved

TobiGr requested a review from Stypox February 2, 2020 11:49

TobiGr reviewed Feb 2, 2020

View reviewed changes

app/src/main/java/org/schabi/newpipe/player/BasePlayer.java Show resolved Hide resolved

Stypox reviewed Feb 2, 2020

View reviewed changes

Removed Unused imports and thrown exception for Unsupported Operation.

94a3b3b

Stypox requested changes Feb 2, 2020

View reviewed changes

app/src/main/java/org/schabi/newpipe/player/BackgroundPlayer.java Show resolved Hide resolved

Removed Exception Handling for Timer Set critical error of .

5b90f16

TobiGr removed this from the 0.19.0 milestone Mar 14, 2020

gkeegan mentioned this pull request Apr 3, 2020

Sleep Timer Feature #3339

Closed

TobiGr mentioned this pull request May 31, 2020

Sugerencia Funcionalidad #3694

Closed

MD77MD mentioned this pull request May 31, 2021

Merge some great NewPipe PRs polymorphicshade/NewPipe#49

Open

3 tasks

litetex marked this pull request as draft October 1, 2021 17:49

litetex closed this Oct 1, 2021

litetex mentioned this pull request Oct 1, 2021

Add sleep timer #2830

Open

litetex mentioned this pull request Oct 10, 2021

Add CODEOWNERS file #7216

Closed

2 tasks

Atemu mentioned this pull request Feb 21, 2022

denied so many times by newpipeTeam for no reason: sleep timer polymorphicshade/NewPipe#142

Closed

5 tasks

zgtm mentioned this pull request Aug 20, 2025

Sleep Timer (new attempt) #12557

Open

5 tasks

Uh oh!

Sleep timer #2892

Sleep timer #2892

Uh oh!

Conversation

javedh-dev commented Dec 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TobiGr left a comment

Choose a reason for hiding this comment

Clean UI and UX

Stop timer

Clean code

Caution when updating dependencies, Gradle etc.

Uh oh!

javedh-dev commented Dec 26, 2019

Uh oh!

javedh-dev commented Dec 28, 2019

Uh oh!

TobiGr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javedh-dev commented Feb 2, 2020

Uh oh!

TobiGr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javedh-dev commented Feb 23, 2020

Uh oh!

ShareASmile commented Feb 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javedh-dev commented Feb 23, 2020

Uh oh!

Stypox commented Feb 23, 2020

Uh oh!

ShareASmile commented Feb 23, 2020

Uh oh!

javedh-dev commented Feb 23, 2020

Uh oh!

javedh-dev commented Feb 23, 2020

Uh oh!

ShareASmile commented Feb 23, 2020

Uh oh!

javedh-dev commented Feb 23, 2020

Uh oh!

ShareASmile commented Feb 27, 2020

Uh oh!

javedh-dev commented Feb 27, 2020

Uh oh!

panther7 commented May 16, 2020

Uh oh!

RickyM7 commented Dec 7, 2020

Uh oh!

javedh-dev commented Dec 7, 2020

Uh oh!

RickyM7 commented Dec 7, 2020

Uh oh!

metzger100 commented Mar 30, 2021

Uh oh!

litetex commented Oct 1, 2021

Uh oh!

tsiflimagas commented Oct 1, 2021

Uh oh!

litetex commented Oct 1, 2021

Uh oh!

tsiflimagas commented Oct 1, 2021

javedh-dev commented Dec 25, 2019 •

edited

Loading

ShareASmile commented Feb 23, 2020 •

edited

Loading