Convert error report timestamps to ISO format

[Nikunj-Aggarwal]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• The current implementation in ErrorActivity was using CURRENT_TIMESTAMP_FORMATTER instead of that, I have converted the LocalDateTime to ISO format

Fixes the following issue(s)

• Fixes Provide proper ISO 8601 timestamps in crash report emails #11865

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[Stypox]

Thank you!
I don't think you need a separate file. You can inline the currentDateToIsoDateFormat function in my opinion, i.e. call LocalDateTime.now().format(DateTimeFormatter.ISO_DATE_TIME) directly.

[Nikunj-Aggarwal]

Thank you! I don't think you need a separate file. You can inline the currentDateToIsoDateFormat function in my opinion, i.e. call LocalDateTime.now().format(DateTimeFormatter.ISO_DATE_TIME) directly.

You are right @Stypox but this file will work as a helper class for other date time related functions still if you feel that this is not required then please let me know here
I will remove it and will make it inline

[Stypox]

Yes please remove it, there is no much use in a utility function that just wraps another function in a very specific way.

[TheAssassin]

Please post the new format so that I can prepare an update for the importer to additionally support the new format. Ideally, please post the entire JSON.

[Nikunj-Aggarwal]

Please post the new format so that I can prepare an update for the importer to additionally support the new format. Ideally, please post the entire JSON.

Could you please elaborate?
I didn't understand what you mean

[Stypox]

I think he means, just open the app built by this PR, go to settings->debug, use the button to make the app crash (which should open the report screen), click on the button to report via mail and send here the json report that your email client would put in the email body.

[Nikunj-Aggarwal]

I think he means, just open the app built by this PR, go to settings->debug, use the button to make the app crash (which should open the report screen), click on the button to report via mail and send here the json report that your email client would put in the email body.

@TheAssassin

{"user_action":"ui error","request":"Dummy","content_language":"en-IN","content_country":"IN","app_language":"en_IN","service":"none","package":"org.schabi.newpipe.debug.bgisotimestamp","version":"0.27.4","os":"Linux Redmi/peux_in/peux:13/TKQ1.221114.001/V816.0.6.0.TKCINXM:user/release-keys 13 - 33","time":"2025-01-12T00:49:24.395","exceptions":["java.lang.RuntimeException: Dummy\n\tat org.schabi.newpipe.settings.DebugSettingsFragment.lambda$onCreatePreferences$5(DebugSettingsFragment.java:85)\n\tat org.schabi.newpipe.settings.DebugSettingsFragment.$r8$lambda$orjSIDahtE9hiky58tDzSrf2FtQ(Unknown Source:0)\n\tat org.schabi.newpipe.settings.DebugSettingsFragment$$ExternalSyntheticLambda5.onPreferenceClick(D8$$SyntheticClass:0)\n\tat androidx.preference.Preference.performClick(Preference.java:1200)\n\tat androidx.preference.Preference.performClick(Preference.java:1182)\n\tat androidx.preference.Preference$1.onClick(Preference.java:182)\n\tat android.view.View.performClick(View.java:7600)\n\tat android.view.View.performClickInternal(View.java:7577)\n\tat android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)\n\tat android.view.View$PerformClick.run(View.java:30186)\n\tat android.os.Handler.handleCallback(Handler.java:942)\n\tat android.os.Handler.dispatchMessage(Handler.java:99)\n\tat android.os.Looper.loopOnce(Looper.java:211)\n\tat android.os.Looper.loop(Looper.java:300)\n\tat android.app.ActivityThread.main(ActivityThread.java:8503)\n\tat java.lang.reflect.Method.invoke(Native Method)\n\tat com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:561)\n\tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:954)\n"],"user_comment":""} 

[TheAssassin]

One thing I am missing is the timezone indicator in this timestamp. For UTC, it should denote a trailing Z, right?

Edit: I mean, we can just assume UTC, too, but I'd rather make it explicit. Python can parse that easily, too. Even if it's just a hack and you append the Z manually to the string, it'd be more transparent.

[Profpatsch]

In this case I’d even add the timezone of the device to the timestamp, because it is kind of important information (e.g. to figure out which day it was locally)

[Profpatsch]

I pushed a small change, now it looks like this:

## Exception
* __User Action:__ ui error
* __Request:__ Dummy
* __Content Country:__ DE
* __Content Language:__ en-DE
* __App Language:__ en_DE
* __Service:__ none
* __Version:__ 0.27.4
* __OS:__ Linux Android 15 - 35
<details><summary><b>Crash log </b></summary><p>

So a proper timestamp with offset;

I wanted to add an extra “Time Zone” field with the name of the time zone (e.g. Europe/Berlin), but that requires rewriting the way the info_labels string is interpolated, otherwise it will not format correctly with the old translations …

[Profpatsch]

Wait the markdown I copied doesn’t even include the string … lol.

I’ll add it

[Profpatsch]

Cool, now it looks like this:

## Exception
* __User Action:__ ui error
* __Request:__ Dummy
* __Content Country:__ DE
* __Content Language:__ en-DE
* __App Language:__ en_DE
* __Service:__ none
* __Timestamp:__ 2025-01-21T16:27:17.936+01:00
* __Package:__ org.schabi.newpipe.debug.bgisotimestamp
* __Service:__ none
* __Version:__ 0.27.4
* __OS:__ Linux Android 15 - 35
<details><summary><b>Crash log </b></summary><p>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[TheAssassin]

I don't see JSON-related changes. This probably just affects the copyable strings.

Edit: nevermind, found it.