This repository was archived by the owner on Jul 5, 2022. It is now read-only.
Fix file downloads#21
Merged
friendlyanon merged 2 commits intoTeamNewPipe:devfrom Mar 10, 2020
blackbox87:legacy-fixes
Merged
Conversation
Without this line HttpURLConnection will throw an EOFException.
2 tasks
mqus
added a commit
to mqus/NewPipe
that referenced
this pull request
Jan 29, 2020
Stypox
pushed a commit
to Stypox/NewPipe
that referenced
this pull request
Feb 1, 2020
|
@blackbox87 When to you plan to release a new NewPipeLegacy release that includes this correction ? |
Contributor
|
@sebma: @friendlyanon is responsible for NewPipe legacy. In case someone else wants to help maintaining the legecay version, please contact me or another member from TeamNewPipe here on GitHub or via IRC in our #newpipe channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that all downloads were throwing a NullPointerException on Jelly Bean and captions were failing to download on any version of Android, so I've fixed that by finding the root of the problem.
I also forgot to enable TLS v1.1/1.2 for Jelly Bean when downloading, so I've fixed that too.