Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code for networktables implementation of sending data to the robot #30

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

maxspier
Copy link
Member

@maxspier maxspier commented Oct 3, 2024

This PR will add the code for all of the base data types supported by networktables to be able to be sent by our code. Now, code only needs to create one instance of a sender for each different data that they would like to send, and send updates through this variable. Code includes sending tag data via network tables to the robot.

This Pull Request, as opened, closes PLANE 184, PLANE 185, and PLANE 186. Approval of this pull request closes PLANE 187.

The code has been tested on the orin and the build server. the code successfully builds and works as intended!

Copy link
Collaborator

@cgpadwick cgpadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor changes for code cleanup and avoiding duplication of the IP address in mutliple files.

@maxspier maxspier requested a review from cgpadwick October 10, 2024 00:57
Copy link
Collaborator

@cgpadwick cgpadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for implementing this @Mixmix00 !

@cgpadwick cgpadwick merged commit 1d48cfc into main Oct 10, 2024
@cgpadwick cgpadwick deleted the ntimplimentation-v2 branch October 10, 2024 02:36
@maxspier maxspier restored the ntimplimentation-v2 branch October 26, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants