Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import PropTypes form separate package #14

Merged
merged 2 commits into from
Oct 9, 2017
Merged

Import PropTypes form separate package #14

merged 2 commits into from
Oct 9, 2017

Conversation

sobstel
Copy link
Contributor

@sobstel sobstel commented Oct 6, 2017

Importing PropTypes from react has been deprecated since quite long and now (in RN 0.49) makes an app to crash.

Copy link
Owner

@TaylorBriggs TaylorBriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure prop-types is in the peerDependencies in package.json? Thanks!

@sobstel
Copy link
Contributor Author

sobstel commented Oct 9, 2017

Done, but added it to "dependencies" as this is what they recommend: https://github.com/facebook/prop-types#how-to-depend-on-this-package

Copy link
Owner

@TaylorBriggs TaylorBriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@TaylorBriggs TaylorBriggs merged commit bf1b5b6 into TaylorBriggs:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants