-
Notifications
You must be signed in to change notification settings - Fork 0
Document the feature-table association split and core/layers responsibilities #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a64a2d8
Expose spatial viewer and move shape color encoding to layers
xinaesthete 4945185
Clarify spatialdata table associations and shape color encoding
xinaesthete a4abb7c
Document core table associations and layer color encoding
xinaesthete a84f099
remove "Hello from " on index page
xinaesthete a417028
change description to mention 'visualizing'
xinaesthete 6c6fe8d
use project typescript version in vscode settings
xinaesthete c40fbee
add headless demo with local blobs and update documentation
xinaesthete 036ffeb
throw error if bad fixture port is set
xinaesthete File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid hardcoding fixture port in CI probe.
The workflow duplicates
38473instead of deriving from one variable, so it can drift from the shared fixture-port config and break readiness checks.Suggested fix
- name: Run integration tests with local server shell: bash run: | + FIXTURE_PORT="${SPATIALDATA_FIXTURE_PORT:-38473}" + # Verify fixtures exist before starting server if [ ! -d "test-fixtures/v0.5.0/blobs.zarr" ]; then echo "Error: Fixtures not found at test-fixtures/v0.5.0/blobs.zarr" echo "Listing test-fixtures directory:" ls -la test-fixtures/ || echo "test-fixtures directory does not exist" exit 1 fi # Start test server in background - pnpm test:server & + SPATIALDATA_FIXTURE_PORT="$FIXTURE_PORT" pnpm test:server & SERVER_PID=$! @@ - if curl -sSf http://localhost:38473/ >/dev/null && \ - curl -sSf http://localhost:38473/v0.5.0/blobs.zarr/zmetadata >/dev/null; then + if curl -sSf "http://localhost:${FIXTURE_PORT}/" >/dev/null && \ + curl -sSf "http://localhost:${FIXTURE_PORT}/v0.5.0/blobs.zarr/zmetadata" >/dev/null; then echo "Test server is up and serving fixtures" break fi - echo "Waiting for test server on http://localhost:38473/ ..." + echo "Waiting for test server on http://localhost:${FIXTURE_PORT}/ ..." sleep 1 done @@ - # Run integration tests (will hit http://localhost:38473/…) + # Run integration tests (will hit http://localhost:${FIXTURE_PORT}/…) pnpm test:integrationAlso applies to: 80-80, 87-87
🤖 Prompt for AI Agents