Update Vite toolchain and fix workspace source resolution for local dev - #21
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 35 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis pull request pins Node.js and pnpm versions via Volta in project configuration, adds TypeScript path aliases for the zarrextra package across multiple tsconfig files, introduces a workspace source aliasing helper function for Vite, and upgrades Vite and related dependencies to newer versions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Around line 41-44: Update the declared Node engine floor from ">=20" to
">=20.19" in the package.json "engines" object (look for the "engines" key and
the "node" property) and update the README fallback note text that currently
says "Node.js >= 20" to explicitly state "Node.js >= 20.19 (or 22.12+)" so the
docs match Vite 8's requirement.
- Line 11: CI fails due to a pnpm version mismatch: package.json declares
packageManager: "pnpm@10.33.0" while both workflows (.github/workflows/test.yml
and .github/workflows/docs.yml) pass a conflicting version input to
pnpm/action-setup@v4 causing ERR_PNPM_BAD_PM_VERSION; fix by removing the
version input from both workflows so pnpm/action-setup uses the packageManager
field as the single source of truth (alternatively, make the workflow version
exactly "10.33.0" to match packageManager), and ensure references to
pnpm/action-setup@v4 and the version input are updated accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f43ab9c2-e1e1-49bd-9068-e78479d81dae
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (9)
README.mdpackage.jsonpackages/core/tsconfig.jsonpackages/react/tsconfig.jsonpackages/vis/demo/tsconfig.jsonpackages/vis/tsconfig.jsonpackages/vis/vite.config.demo.tspnpm-workspace.yamlvite.config.base.ts
| "engines": { | ||
| "node": ">=20", | ||
| "pnpm": ">=10" | ||
| }, |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n package.json | head -50Repository: Taylor-CCB-Group/SpatialData.js
Length of output: 2266
🏁 Script executed:
find . -name "pnpm-workspace.yaml" -o -name ".pnpmfile.cjs" | head -5Repository: Taylor-CCB-Group/SpatialData.js
Length of output: 96
🏁 Script executed:
cat -n pnpm-workspace.yamlRepository: Taylor-CCB-Group/SpatialData.js
Length of output: 775
🏁 Script executed:
find . -iname "README*" -type f | head -5Repository: Taylor-CCB-Group/SpatialData.js
Length of output: 190
🏁 Script executed:
cat README.md | grep -i "node" -C 3Repository: Taylor-CCB-Group/SpatialData.js
Length of output: 682
🌐 Web query:
Vite 8 Node version requirements minimum support
💡 Result:
Vite 8 requires Node.js 20.19+ or 22.12+ as the minimum supported versions. These are the same requirements as Vite 7, ensuring support for require(esm) without flags for ESM-only distribution.
Citations:
- 1: https://github.com/vitejs/vite/blob/8e05b61d/packages/vite/CHANGELOG.md
- 2: https://vite.dev/blog/announcing-vite8
- 3: https://medium.com/@onix_react/vite-8-0-released-fbf23ade5f79
- 4: https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md
Tighten the declared Node floor to match Vite 8 requirements.
The current engines.node: ">=20" is too broad. Vite 8 requires Node 20.19+ or 22.12+, so Node 20.0–20.18 installations will satisfy the engines check but fail during local dev/test. Update to >=20.19 and mirror this in the README's fallback note (currently states "Node.js >= 20").
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` around lines 41 - 44, Update the declared Node engine floor
from ">=20" to ">=20.19" in the package.json "engines" object (look for the
"engines" key and the "node" property) and update the README fallback note text
that currently says "Node.js >= 20" to explicitly state "Node.js >= 20.19 (or
22.12+)" so the docs match Vite 8's requirement.
1 participant
Summary
@vitejs/plugin-react6, and Vitest 4@spatialdata/zarrextracleanscript for resetting generated build output during local testingreactandreact-domin the vis demo config to avoid invalid hook calls in devTesting
pnpm installpnpm --filter @spatialdata/vis exec vite build --config vite.config.demo.tspnpm --filter @spatialdata/vis testpnpm --filter @spatialdata/react exec tsc --noEmit -p tsconfig.jsonpnpm --filter @spatialdata/react buildSummary by CodeRabbit
Documentation
Chores