Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add subcommand to install LaunchAgents wrapper for watch #890

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Feature: Add subcommand to install LaunchAgents wrapper for watch #890

wants to merge 16 commits into from

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Apr 24, 2022

Implement #889 progammatically

@glensc glensc self-assigned this Apr 24, 2022
glensc
glensc commented Apr 24, 2022
View reviewed changes
plextraktsync/com.github.plextraktsync.watch.plist
<string>watch</string>
</array>
<key>LimitLoadToSessionType</key>
<string>Aqua</string>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why Aqua?

from this link Background seems more appropriate?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I used aqua based on a old example. You are right that Background might be better.

Setting a nice level might be a good idea though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send an example for nice level. perhaps using suggest code change feature:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bas-Man I can't see the suggestion on the web, but had a glimpse of it in the email. Did you delete it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glensc the pending change request is on this pull request.

@Bas-Man please reply in the thread where the question was asked.

But, I don't see your changes, perhaps you forgot to publish review?

@glensc
Copy link
Collaborator Author

glensc commented Apr 24, 2022 •
edited
Loading

the subcommand probably should have such call conventions, inspired by brew services:

# to show the state
plextraktsync service
plextraktsync service info

# register/unregister
plextraktsync service start
plextraktsync service stop

@Bas-Man
Copy link

Bas-Man commented May 4, 2022

@glensc the pending change request is on this pull request.

@glensc glensc changed the title Add subcommand to install LaunchAgents wrapper for watch Feature: Add subcommand to install LaunchAgents wrapper for watch Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bas-Man Bas-Man Bas-Man left review comments

Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @Bas-Man