feat: globalize smoothness of group homomorphisms - #6402
tauceti-review-bot[bot] merged 3 commits into
Conversation
Prove that a bundled group homomorphism between smoothly multiplicative manifolds is C^n everywhere once it is C^n at the identity. Generate the additive analogue with to_additive. State the result for any MonoidHomClass with only a monoid target. This is the local-to-global boundary consumed after the closed-graph argument establishes smoothness near the identity; subgroup atlases and automatic smoothness remain downstream.
There was a problem hiding this comment.
✅ reuse — now passing on a779dba.
There was a problem hiding this comment.
🟡 attribution — request_changes codex/gpt-5.6-sol
The central Mathlib analogue named in the PR description is not credited in the code.
TauCeti/Geometry/Manifold/Algebra/Monoid.lean:108— The theorem docstring omits credit for Mathlib's directly analogouscontinuous_of_continuousAt_one, which the PR description identifies as its structural model. Fix: Add a docstring reference tocontinuous_of_continuousAt_oneas the continuous analogue motivating this construction.
Reply in this thread to contest a finding; that re-runs only this rubric and posts an answer here. (To fix it, just push a commit — that re-reviews on its own. To contest again after an answer, post a NEW reply rather than editing an old one.)
codex/gpt-5.6-sol · 25s · 82.2k in / 867 out tokens · reviewing this diff · rubric
There was a problem hiding this comment.
✅ generality — now passing on a779dba.
AI review — approvedEach rubric is judged independently by multiple review agents; the PR merges only once every rubric is green — any rubric that is not green (changes requested, blocked, errored, stale, or not yet run) blocks the merge. See the rubrics.
♻️ = approved on an earlier commit, re-run before merge. Reviewing this diff at head |
Weaken the codomain assumption to MulOneClass, matching the algebra used by the proof and the adjacent continuous API. Reuse Mathlib's contMDiffAt_mul_left for the translated source germ instead of rebuilding it from primitives.
Reference Mathlib's continuous_of_continuousAt_one in the theorem docstring, making the structural source of the local-to-global smoothness argument explicit. The theorem statement and proof remain unchanged.
b14612f
This PR globalizes
C^nregularity of a group homomorphism from the identity to every source point for the LieGroups Layer 2 automatic-smoothness path.Roadmap: RepresentationTheory
Summary
Add
TauCeti.contMDiff_of_contMDiffAt_one: for any bundled morphism satisfyingMonoidHomClass, from a group manifold to a smoothly multiplicativeMulOneClassmanifold, smoothness at the identity implies smoothness everywhere. Left translation moves the identity germ to an arbitrary point and the homomorphism law identifies the translated expression with the original map.to_additivesupplies the zero-based additive analogue. The theorem documentation credits Mathlib's structurally analogouscontinuous_of_continuousAt_one.This is the local-to-global boundary used after a closed-graph argument establishes smoothness at the identity. The statement keeps arbitrary differentiability order, field, and source/target models; it assumes neither finite dimensionality nor smooth inversion. No Mathlib source is vendored. The API uses Mathlib's
ContMDiffAt.comp_of_eq,MonoidHomClass, and smooth multiplication, at the same structural generality as the adjacent continuous theoremcontinuous_of_continuousAt_one.Roadmap target
This advances
RepresentationTheory/LieGroups/README.md, Layer 2, “the closed-subgroup (Cartan) theorem,” specifically Cartan's automatic-smoothness corollary for continuous homomorphisms. Its downstream consumer isRepresentationTheory/SpinRepresentations/README.md, Layer 3, “the differential of the double cover”: the abstract Spin and special-orthogonal group homomorphism must become smooth beforelieMapcan identify its differential. After this PR, the LieGroups milestone still needs the product chart and subgroup atlas, the embedded subgroup structure and graph-local smoothness argument, and the concrete Spin/SO Lie structures.Verification
f80c298a33b350b5270a56c125056b88935e9771spinrep-validate run -- lake build— passed (11176jobs)spinrep-validate run -- lake exe axioms— passed (111943TauCeti declarations; onlypropext,Classical.choice, andQuot.sound)git diff --check— passedScale and generality
The aggregate changes one existing file by 37 added lines and one module-docstring line replacement. It adds one multiplicative theorem and its generated additive counterpart, for arbitrary
n : ℕ∞ω, a common nontrivially normed field, unrelated source and target models, a group source, aMulOneClasstarget, and any bundled morphism implementingMonoidHomClass. The proof uses only smooth multiplication; the inverse is a fixed source element.Scope
ContMDiffAt.comp_of_eq, smooth pointwise multiplication,MonoidHomClass.map_mul, and group cancellationcontMDiff_of_contMDiffAt_oneand itsto_additivezero-based counterpartlieMapand ultimately the Spin/SO double-cover differential🤖 GPT-5.6 Sol high · TauCetiWorker @ 7518d4150b846c4524423341570c031027a1d92c · rubrics @ afb424eda89e8ac96d9eb69f6a88972055a4cd1b · local review @ b533e561b6d44df071c31335ed4a63ae647507d2 · fixed: attribution, generality, reuse