fix(vllm): correct qwen-3.8 spec.files for the philbert layout - #4561
Conversation
The source moved to philbert440 but spec.files still listed cyankiwi's five shards plus merges.txt/vocab.json, none of which exist in that repo. The model-downloader init container fetches exactly these names and exits 1 on a 404, so any regeneration of the Deployment crashlooped the pod. Verified all ten names resolve at the pinned revision; the three removed ones return 404.
|
Warning Review limit reached
Next review available in: 26 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@@ spec.files @@
# inference.llmkube.dev/v1alpha1/Model/ai/qwen38-27b-vllm
! - seven list entries removed:
- - model-00001-of-00005.safetensors
- - model-00002-of-00005.safetensors
- - model-00003-of-00005.safetensors
- - model-00004-of-00005.safetensors
- - model-00005-of-00005.safetensors
- - merges.txt
- - vocab.json
! + two list entries added:
+ - model.safetensors
+ - model-mtp.safetensors
|
AI Automated ReviewAnalysis engine: omniroute@http://litellm.ai.svc.cluster.local/v1 (openai) Recommendation: Approve. The change correctly updates Standards Compliance
Unknowns or Needs Verification
|
#4551 moved
sourceto philbert440 but leftspec.fileslisting cyankiwi's layout. Themodel-downloaderinit container fetches exactly those names andexit 1s on a 404, so the pod crashlooped (Init:Error, 5 restarts) as soon as the Deployment was regenerated.Latent until now: the running Deployment carried a correct
MODEL_FILESenv from an earlier resolution, and the old cyankiwi weights on disk let the downloader's "kept cached copy" branch mask the wrong list. Resuming the Kustomization regenerated the Deployment and removing the stale weights took away the fallback.Verified against the pinned revision
7908d42a:Removed, all 404 at that revision:
model-0000{1..5}-of-00005.safetensors,merges.txt,vocab.json(philbert folds merges/vocab intotokenizer.json).Deleting and recreating the Model CR does not help — the operator reproduces the list straight from
spec.files, so the fix has to be in git.