Skip to content

fix(renovate): group all talos packages into a single PR - #4370

Merged
Tanguille merged 7 commits into
mainfrom
renovate/talos-group
Aug 6, 2026
Merged

fix(renovate): group all talos packages into a single PR#4370
Tanguille merged 7 commits into
mainfrom
renovate/talos-group

Conversation

@Tanguille

@Tanguille Tanguille commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Updates to group all talos packages into a single PR. Changes matchDatasources from ["docker", "aqua", "github-releases"] to ["docker", "github-releases"] and matchPackageNames from ["/siderolabs\/(talos|installer)/"] to ["/siderolabs\/"].

Summary by CodeRabbit

  • Chores
    • Improved repository housekeeping by excluding local worktree and cloned dependency artifacts from tracked changes.
    • Refined automated update grouping for Talos-related packages, including release and installer updates, making maintenance notifications more organized.
    • Added clearer categorization for these development-only exclusions and update rules.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Tanguille, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6fcbb66b-032e-4783-9112-ae26771b2de2

📥 Commits

Reviewing files that changed from the base of the PR and between 83c6243 and 2952c68.

📒 Files selected for processing (2)
  • .gitignore
  • .renovaterc.json5
📝 Walkthrough

Walkthrough

The change adds two Slim paths to .gitignore and updates the Renovate Talos grouping rule to match all siderolabs/* packages while retaining Docker and GitHub Releases.

Changes

Slim ignore rules

Layer / File(s) Summary
Slim path exclusions
.gitignore
The Slim ignore section excludes .slim/worktrees.json and .slim/clonedeps/repos/.

Renovate package grouping

Layer / File(s) Summary
Talos grouping rule
.renovaterc.json5
The Talos rule removes Aqua matching, retains Docker and GitHub Releases, and matches all siderolabs/* packages.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main Renovate configuration change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch renovate/talos-group

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

DeepSource Code Review

We reviewed changes in 83c6243...2952c68 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Aug 6, 2026 7:08a.m. Review ↗
Shell Aug 6, 2026 7:08a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Tanguille
Tanguille marked this pull request as ready for review August 6, 2026 07:08
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

AI Automated Review

Analysis engine: omniroute@http://litellm.ai.svc.cluster.local/v1 (openai)

Recommendation

Request changes. The PR intends to group all Talos packages into a single Renovate PR, but it removes the aqua datasource, which means talosctl updates via aqua (.mise.toml) will still be handled in a separate PR. Additionally, the .gitignore changes are unrelated to the Renovate change and should be removed.

Change-by-change findings

.renovaterc.json5

  • The matchPackageNames change to /siderolabs\/ correctly broadens the grouping to all siderolabs/* packages, which is the intended goal.
  • Major issue: Removing aqua from matchDatasources means the talosctl update via aqua (.mise.toml) will no longer be grouped. The PR body explicitly states this removal, but it contradicts the PR title and goal of grouping all Talos packages. The comment now says “one PR instead of two,” but with aqua removed there will still be a separate aqua PR, so the comment is misleading.

.gitignore

  • The additions for .slim/worktrees.json and .slim/clonedeps/repos/ are unrelated to the Renovate grouping change. They appear to be from a previous commit merged into the branch. This violates the repository convention of keeping changes small and focused.

Sources

  • PR metadata and diff
  • Repository history (e.g., chore(mise): update tool aqua:siderolabs/talos and chore(github-release): update release siderolabs/talos show separate PRs that the grouping aims to consolidate)
  • Repository standards (AGENTS.md)

Standards Compliance

  • The Renovate config change follows the existing pattern of grouped updates.
  • The .gitignore change is unrelated to the PR scope and does not follow the “keep changes small and focused” convention.
  • No shell scripts or Kubernetes manifests are touched, so no flate/shellcheck validation is required.

Tool Harness Findings

The tool harness ran two commands:

  • git_status_short returned a list of untracked files (harness artifacts), no issues.
  • git_diff_stat returned empty output, so no additional diff statistics were available.

The harness stopped with a request-error, so no further validation was performed.

Unknowns or Needs Verification

  • The Renovate config syntax (e.g., whether the regex /siderolabs\/ is accepted by Renovate) was not validated. The pattern appears correct, but it should be confirmed with a Renovate dry-run.
  • The removal of aqua from matchDatasources is not explained in the PR body. If it is intentional, the PR should clarify why talosctl updates are excluded from the grouping.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline findings from the automated review (summary in the sticky comment).

Comment thread .renovaterc.json5
groupName: "talos",
matchDatasources: ["docker", "aqua", "github-releases"],
matchPackageNames: ["/siderolabs\\/(talos|installer)/"]
matchDatasources: ["docker", "github-releases"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Major (bug): Removing 'aqua' from matchDatasources means talosctl updates via aqua (.mise.toml) will no longer be grouped into the Talos PR, so the PR does not achieve its stated goal of grouping all talos packages into a single PR.

Automated finding from AI PR review.

Comment thread .gitignore
# .slim/worktrees/ holds live git worktrees
.slim/worktrees/
.slim/worktrees.json
# END oh-my-opencode-slim worktrees

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor (style): The .gitignore changes (worktrees.json and clonedeps) are unrelated to the renovate grouping change and should be removed or kept in a separate PR.

Automated finding from AI PR review.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.renovaterc.json5:
- Line 81: Update the matchPackageNames pattern in the Renovate configuration to
include the missing trailing regex delimiter, preserving the intended match for
siderolabs/* packages and ensuring Renovate accepts the pattern.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d7f9f4cf-a8cf-42f7-bca7-a73781ee81ac

📥 Commits

Reviewing files that changed from the base of the PR and between 83c6243 and 2952c68.

📒 Files selected for processing (2)
  • .gitignore
  • .renovaterc.json5

Comment thread .renovaterc.json5
@Tanguille
Tanguille merged commit ad5570b into main Aug 6, 2026
15 checks passed
@Tanguille
Tanguille deleted the renovate/talos-group branch August 6, 2026 12:54
Tanguille added a commit that referenced this pull request Aug 6, 2026
`/siderolabs\\/` is not a valid regex literal: the trailing slash is escaped, so the
pattern never terminates. Renovate fails config validation and skips the repo entirely,
which has silently stopped all dependency updates since #4370 merged.

Verified with renovate 44.14.3 under node 24: config now validates, and the opencode
customManager extracts all three npm plugins (cc-safety-net 1.0.6,
@tarquinen/opencode-dcp 3.1.14, oh-my-opencode-slim 2.2.10).
Tanguille added a commit that referenced this pull request Aug 6, 2026
Renovate reads a /.../-delimited string as a regex. In "/siderolabs\\/" the trailing
slash is escaped, so the literal never terminates: config validation fails, which aborts
mergeRenovateConfig and makes Renovate skip the whole repository rather than just that
rule. No Renovate PRs have been opened since #4370 merged at 12:54Z.

Verified with renovate 44.14.3 under node 24 against this config: validator errors before,
"Config validated successfully" after.
Tanguille added a commit that referenced this pull request Aug 6, 2026
…lumbing

42 of the last 83 reviews stopped at exactly the default 4 tool calls and none
exceeded it, so the call budget bound every second review while the 900s wall
clock went unspent. All 20 run_command calls in that sample were git_diff_stat,
git_diff_name_only or git_status_short, re-deriving a diff the corpus already
carries; on #4370 that was half the budget, and the review then called an
unterminated regex correct without ever opening .renovaterc.json5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant