fix(renovate): group all talos packages into a single PR - #4370
Conversation
|
Warning Review limit reached
Next review available in: 55 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change adds two Slim paths to ChangesSlim ignore rules
Renovate package grouping
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 6, 2026 7:08a.m. | Review ↗ | |
| Shell | Aug 6, 2026 7:08a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
AI Automated ReviewAnalysis engine: omniroute@http://litellm.ai.svc.cluster.local/v1 (openai) RecommendationRequest changes. The PR intends to group all Talos packages into a single Renovate PR, but it removes the Change-by-change findings
|
| groupName: "talos", | ||
| matchDatasources: ["docker", "aqua", "github-releases"], | ||
| matchPackageNames: ["/siderolabs\\/(talos|installer)/"] | ||
| matchDatasources: ["docker", "github-releases"], |
There was a problem hiding this comment.
Automated finding from AI PR review.
| # .slim/worktrees/ holds live git worktrees | ||
| .slim/worktrees/ | ||
| .slim/worktrees.json | ||
| # END oh-my-opencode-slim worktrees |
There was a problem hiding this comment.
Minor (style): The .gitignore changes (worktrees.json and clonedeps) are unrelated to the renovate grouping change and should be removed or kept in a separate PR.
Automated finding from AI PR review.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.renovaterc.json5:
- Line 81: Update the matchPackageNames pattern in the Renovate configuration to
include the missing trailing regex delimiter, preserving the intended match for
siderolabs/* packages and ensuring Renovate accepts the pattern.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d7f9f4cf-a8cf-42f7-bca7-a73781ee81ac
📒 Files selected for processing (2)
.gitignore.renovaterc.json5
`/siderolabs\\/` is not a valid regex literal: the trailing slash is escaped, so the pattern never terminates. Renovate fails config validation and skips the repo entirely, which has silently stopped all dependency updates since #4370 merged. Verified with renovate 44.14.3 under node 24: config now validates, and the opencode customManager extracts all three npm plugins (cc-safety-net 1.0.6, @tarquinen/opencode-dcp 3.1.14, oh-my-opencode-slim 2.2.10).
Renovate reads a /.../-delimited string as a regex. In "/siderolabs\\/" the trailing slash is escaped, so the literal never terminates: config validation fails, which aborts mergeRenovateConfig and makes Renovate skip the whole repository rather than just that rule. No Renovate PRs have been opened since #4370 merged at 12:54Z. Verified with renovate 44.14.3 under node 24 against this config: validator errors before, "Config validated successfully" after.
…lumbing 42 of the last 83 reviews stopped at exactly the default 4 tool calls and none exceeded it, so the call budget bound every second review while the 900s wall clock went unspent. All 20 run_command calls in that sample were git_diff_stat, git_diff_name_only or git_status_short, re-deriving a diff the corpus already carries; on #4370 that was half the budget, and the review then called an unterminated regex correct without ever opening .renovaterc.json5.
Updates to group all talos packages into a single PR. Changes matchDatasources from ["docker", "aqua", "github-releases"] to ["docker", "github-releases"] and matchPackageNames from ["/siderolabs\/(talos|installer)/"] to ["/siderolabs\/"].
Summary by CodeRabbit