Skip to content

feat(network): migrate TLSRoute from v1alpha2 to v1 - #4369

Closed
Tanguille wants to merge 3 commits into
mainfrom
feat/gateway-api-v1.6-tlsroute-migration
Closed

feat(network): migrate TLSRoute from v1alpha2 to v1#4369
Tanguille wants to merge 3 commits into
mainfrom
feat/gateway-api-v1.6-tlsroute-migration

Conversation

@Tanguille

Copy link
Copy Markdown
Owner

Migrate TLSRoute from v1alpha2 to v1

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c5f60f3e-455f-46dc-80d0-55d0017bf4bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

DeepSource Code Review

We reviewed changes in 9921616...15ed34b on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Aug 6, 2026 7:06a.m. Review ↗
Shell Aug 6, 2026 7:06a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Tanguille

Copy link
Copy Markdown
Owner Author

Superseded. The diff here only ever contained .gitignore/.ignore changes, and the TLSRoute work it was named for is obsolete: #4378 consolidates the three per-app tlsroute.yaml files into kubernetes/apps/network/external-service/resourceset-tls.yaml, so the v1alpha2 to v1 bump is now a one-line change there rather than three file edits.

Gateway API 1.6 (the branch's original goal) is separately blocked: Envoy Gateway 1.8.3 is compiled against gateway-api v1.5.1 and bundles those CRDs via its chart. envoyproxy/gateway@main already vendors v1.6.1, so 1.6 arrives as a tag bump when EG 1.9.0 ships.

@Tanguille Tanguille closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant