fix(nextcloud): right-size resources to prevent nginx OOMKill - #4350
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Nextcloud HelmRelease increases Nginx memory resources, reduces PHP ChangesNextcloud resource tuning
Estimated code review effort: 1 (Trivial) | ~5 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 5, 2026 5:36a.m. | Review ↗ | |
| Shell | Aug 5, 2026 5:36a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
@@ data.php.ini @@
# v1/ConfigMap/default/nextcloud-phpconfig
! ± value change in multiline text (one insert, one deletion)
max_execution_time = 600
default_socket_timeout = 300
curl.cainfo = /etc/ssl/certs/ca-certificates.crt
extension=imagick
extension=exif
extension=intl
extension=gd
- memory_limit = 8G
+ memory_limit = 512M
opcache.memory_consumption = 512
opcache.max_accelerated_files = 20000
opcache.revalidate_freq = 60
@@ spec.template.metadata.annotations.php-config-hash @@
# apps/v1/Deployment/default/nextcloud
! ± value change
- 7dfdcde7c08e1631e106367af48f6b92d22c99456f3427fd5780612da5c7dd90
+ 1bbf6cbbb41376ae5d98fc4f53dfd7c12ecea867ea4b192622b55290c0e964b1
@@ spec.template.spec.containers.nextcloud-nginx.resources.limits.memory @@
# apps/v1/Deployment/default/nextcloud
! ± value change
- 128Mi
+ 256Mi
@@ spec.template.spec.containers.nextcloud-nginx.resources.requests.memory @@
# apps/v1/Deployment/default/nextcloud
! ± value change
- 64Mi
+ 128Mi
@@ spec.jobTemplate.spec.template.spec.containers.nextcloud-cron.resources @@
# batch/v1/CronJob/default/nextcloud-cron
! + two map entries added:
+ limits:
+ cpu: "1"
+ memory: 2Gi
+ requests:
+ cpu: 100m
+ memory: 500Mi
|
@@ spec.values.cronjob.cronjob @@
# helm.toolkit.fluxcd.io/v2/HelmRelease/default/nextcloud
! + one map entry added:
+ resources:
+ limits:
+ cpu: "1"
+ memory: 2Gi
+ requests:
+ cpu: 100m
+ memory: 500Mi
@@ spec.values.nextcloud.phpConfigs.php.ini @@
# helm.toolkit.fluxcd.io/v2/HelmRelease/default/nextcloud
! ± value change in multiline text (one insert, one deletion)
max_execution_time = 600
default_socket_timeout = 300
curl.cainfo = /etc/ssl/certs/ca-certificates.crt
extension=imagick
extension=exif
extension=intl
extension=gd
- memory_limit = 8G
+ memory_limit = 512M
opcache.memory_consumption = 512
opcache.max_accelerated_files = 20000
opcache.revalidate_freq = 60
@@ spec.values.nginx.resources.limits.memory @@
# helm.toolkit.fluxcd.io/v2/HelmRelease/default/nextcloud
! ± value change
- 128Mi
+ 256Mi
@@ spec.values.nginx.resources.requests.memory @@
# helm.toolkit.fluxcd.io/v2/HelmRelease/default/nextcloud
! ± value change
- 64Mi
+ 128Mi
|
AI Automated ReviewAnalysis engine: omniroute@http://litellm.ai.svc.cluster.local/v1 (openai) RecommendationApprove. The PR right-sizes Nextcloud resources to prevent nginx sidecar OOMKills. The changes are directionally correct, internally consistent, and well-scoped to a single HelmRelease. One minor convention deviation is noted below. Change-by-change findings
Standards Compliance
Tool Harness FindingsThe tool harness ran Unknowns or Needs Verification
Required checks
|
Fix Nextcloud nginx sidecar OOMKill by increasing memory limits.
Changes:
Verified against live cluster state (pod nextcloud-557c77f968-j5l76).
Summary by CodeRabbit