fix(gitignore): ignore suffixed age key backups - #4303
Conversation
`*.key` and `/age.key` both miss names like `age.key.bak-x25519-only`, which was sitting untracked in this public repo and decrypts the tracked sops files. One `git add -A` would have published it.
📝 WalkthroughWalkthroughThe ChangesIgnore pattern update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 2, 2026 3:02p.m. | Review ↗ | |
| Shell | Aug 2, 2026 3:02p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.gitignore:
- Around line 5-7: Update the age key ignore rule from age.key* to /age.key* so
matching key files and backups remain limited to the repository root, preserving
the existing protection against suffixed backups.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 50dbc110-76f7-4ef9-9879-067d377508a3
📒 Files selected for processing (1)
.gitignore
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Tanguille/LLMKube(auto-detected)Tanguille/toolhive(auto-detected)Tanguille/pr-reviewer-action(auto-detected)Tanguille/2x-R9700-RDNA4-GFX1201-sglang-inference(auto-detected)
| # `*.key` misses suffixed backups like age.key.bak-x25519-only, which decrypt the | ||
| # tracked sops files in this PUBLIC repo. Supersedes the old `/age.key`. | ||
| age.key* |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Preserve the repository-root scope.
The previous /age.key rule matched only the repository root. The new age.key* pattern matches files and directories with that basename at any directory level. Use /age.key* if only root-level age key files and backups must be ignored.
Proposed fix
-age.key*
+/age.key*📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # `*.key` misses suffixed backups like age.key.bak-x25519-only, which decrypt the | |
| # tracked sops files in this PUBLIC repo. Supersedes the old `/age.key`. | |
| age.key* | |
| # `*.key` misses suffixed backups like age.key.bak-x25519-only, which decrypt the | |
| # tracked sops files in this PUBLIC repo. Supersedes the old `/age.key`. | |
| /age.key* |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.gitignore around lines 5 - 7, Update the age key ignore rule from age.key*
to /age.key* so matching key files and backups remain limited to the repository
root, preserving the existing protection against suffixed backups.
AI Automated ReviewAnalysis engine: qwen-3.6-fast@http://litellm.ai.svc.cluster.local/v1 (openai) Recommendation: Approve This is a targeted, low-risk Change-by-Change Findings
Standards Compliance
Tool Harness FindingsTool harness planning was pending; no findings to report. Unknowns or Needs VerificationNone. The change is self-contained and verifiable from the diff and repository standards. |
age.key.bak-x25519-onlywas sitting untracked in this public repo..gitignorehad*.keyand/age.key; the filename ends-onlyso neither matched. Verified by decryption that this key opens the tracked sops files.Nothing leaked. It was one
git add -Aaway.age.key*also makes the existing/age.keyredundant, so that line is removed rather than left dead.Summary by CodeRabbit
age.key, helping prevent them from being tracked accidentally.