fix(container): update image ghcr.io/ggml-org/llama.cpp (5b69b5a ➔ f8ec293) - #4293
Conversation
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Aug 2, 2026 8:35a.m. | Review ↗ | |
| Shell | Aug 2, 2026 8:35a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
📝 WalkthroughWalkthroughThe three Kubernetes Changesllama.cpp image digest updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
@@ spec.image @@
# inference.llmkube.dev/v1alpha1/InferenceService/ai/qwen3-embedding
! ± value change
- ghcr.io/ggml-org/llama.cpp:server-vulkan@sha256:5b69b5a99886b6bdc24c281b9a041c21e0e9d5502018c55098d4b09cac6ee5a4
+ ghcr.io/ggml-org/llama.cpp:server-vulkan@sha256:f8ec293aa54a6d42fa60bbfe3f37f6d4878d9df0d2e96e80f5d2dc514bcea182
@@ spec.image @@
# inference.llmkube.dev/v1alpha1/InferenceService/ai/qwen35-2b
! ± value change
- ghcr.io/ggml-org/llama.cpp:server-vulkan@sha256:5b69b5a99886b6bdc24c281b9a041c21e0e9d5502018c55098d4b09cac6ee5a4
+ ghcr.io/ggml-org/llama.cpp:server-vulkan@sha256:f8ec293aa54a6d42fa60bbfe3f37f6d4878d9df0d2e96e80f5d2dc514bcea182
@@ spec.image @@
# inference.llmkube.dev/v1alpha1/InferenceService/ai/vmcp-embedding
! ± value change
- ghcr.io/ggml-org/llama.cpp:server-vulkan@sha256:5b69b5a99886b6bdc24c281b9a041c21e0e9d5502018c55098d4b09cac6ee5a4
+ ghcr.io/ggml-org/llama.cpp:server-vulkan@sha256:f8ec293aa54a6d42fa60bbfe3f37f6d4878d9df0d2e96e80f5d2dc514bcea182
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
kubernetes/apps/ai/llmkube/models/qwen3-embedding.yaml (1)
39-39: 🩺 Stability & Availability | 🔵 TrivialValidate the shared Vulkan image on AMD hardware before rollout.
After Flux reconciliation, run smoke tests for all three services and confirm Vulkan execution without CPU fallback:
/v1/embeddingsforqwen3-embedding.- Qwen3.5 GDN chat with
jinja: trueforqwen35-2b./v1/embeddingsthrough the ToolHive dependency path forvmcp-embedding.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@kubernetes/apps/ai/llmkube/models/qwen3-embedding.yaml` at line 39, Validate the shared Vulkan image on AMD hardware after Flux reconciliation by smoke-testing all three affected services: /v1/embeddings for qwen3-embedding in kubernetes/apps/ai/llmkube/models/qwen3-embedding.yaml:39-39, Qwen3.5 GDN chat with jinja=true for qwen35-2b in kubernetes/apps/ai/llmkube/models/qwen35-2b.yaml:36-36, and /v1/embeddings through the ToolHive dependency path for vmcp-embedding in kubernetes/apps/ai/llmkube/models/vmcp-embedding.yaml:45-45; confirm each uses Vulkan execution without CPU fallback.Source: Linked repositories
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@kubernetes/apps/ai/llmkube/models/qwen3-embedding.yaml`:
- Line 39: Validate the shared Vulkan image on AMD hardware after Flux
reconciliation by smoke-testing all three affected services: /v1/embeddings for
qwen3-embedding in kubernetes/apps/ai/llmkube/models/qwen3-embedding.yaml:39-39,
Qwen3.5 GDN chat with jinja=true for qwen35-2b in
kubernetes/apps/ai/llmkube/models/qwen35-2b.yaml:36-36, and /v1/embeddings
through the ToolHive dependency path for vmcp-embedding in
kubernetes/apps/ai/llmkube/models/vmcp-embedding.yaml:45-45; confirm each uses
Vulkan execution without CPU fallback.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4b9b190b-0118-4522-b340-1c3e57cd4d47
📒 Files selected for processing (3)
kubernetes/apps/ai/llmkube/models/qwen3-embedding.yamlkubernetes/apps/ai/llmkube/models/qwen35-2b.yamlkubernetes/apps/ai/llmkube/models/vmcp-embedding.yaml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Tanguille/LLMKube(auto-detected)Tanguille/toolhive(auto-detected)Tanguille/pr-reviewer-action(auto-detected)Tanguille/2x-R9700-RDNA4-GFX1201-sglang-inference(auto-detected)
This PR contains the following updates:
5b69b5a→f8ec293Configuration
📅 Schedule: (in timezone Europe/Brussels)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.