fix(container): update image ghcr.io/tanguille/sglang-rdna4 (615cb42 ➔ 51ececd) - autoclosed - #4255
Conversation
📝 WalkthroughWalkthroughThe qwen36-27b SGLang ChangesSGLang image update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
@@ spec.image @@
# inference.llmkube.dev/v1alpha1/InferenceService/ai/qwen36-27b
! ± value change
- ghcr.io/tanguille/sglang-rdna4:v0.5.16-gfx1201@sha256:615cb4265400f5468da4c32221f0086df075b126ce8dbfa78d998e844a5e424d
+ ghcr.io/tanguille/sglang-rdna4:v0.5.16-gfx1201@sha256:51ececd579cec3785357c07e318c2badf9e333ea07c7fd47a0e19fcb4a7c2b24
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@kubernetes/apps/ai/llmkube/models/qwen36-27b-sglang.yaml`:
- Line 80: The HiCache directory suffix must match the updated image digest.
Update the suffix in the manifest’s HiCache configuration, including the
corresponding entries around the additional referenced locations, from
sglang-v0.5.16_awq-f541031d to the suffix derived from digest
51ececd579cec3785357c07e318c2badf9e333ea07c7fd47a0e19fcb4a7c2b24, so caches from
the previous image are not reused.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 36d2dd19-3335-4b9f-b521-3ae46edd2680
📒 Files selected for processing (1)
kubernetes/apps/ai/llmkube/models/qwen36-27b-sglang.yaml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Tanguille/LLMKube(auto-detected)Tanguille/2x-R9700-RDNA4-GFX1201-sglang-inference(auto-detected)
| # Operator default binds :: (IPv6-only on this IPv4 cluster); override to v4. | ||
| bindAddress: 0.0.0.0 | ||
| image: ghcr.io/tanguille/sglang-rdna4:v0.5.16-gfx1201@sha256:615cb4265400f5468da4c32221f0086df075b126ce8dbfa78d998e844a5e424d | ||
| image: ghcr.io/tanguille/sglang-rdna4:v0.5.16-gfx1201@sha256:51ececd579cec3785357c07e318c2badf9e333ea07c7fd47a0e19fcb4a7c2b24 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Bump the HiCache directory suffix with the new image digest.
The manifest explicitly requires this suffix to change whenever the image digest changes. Leaving sglang-v0.5.16_awq-f541031d unchanged allows KV pages produced by the previous image to be reused by the new image, potentially serving stale or incompatible cache data.
Also applies to: 124-127
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@kubernetes/apps/ai/llmkube/models/qwen36-27b-sglang.yaml` at line 80, The
HiCache directory suffix must match the updated image digest. Update the suffix
in the manifest’s HiCache configuration, including the corresponding entries
around the additional referenced locations, from sglang-v0.5.16_awq-f541031d to
the suffix derived from digest
51ececd579cec3785357c07e318c2badf9e333ea07c7fd47a0e19fcb4a7c2b24, so caches from
the previous image are not reused.
This PR contains the following updates:
615cb42→51ececdConfiguration
📅 Schedule: (in timezone Europe/Brussels)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.