fix(container): update image ghcr.io/tanguille/sglang-rdna4 (7ed8834 ➔ 615cb42) - #4234
Conversation
📝 WalkthroughWalkthroughThe Kubernetes ChangesSGLang image update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
@@ spec.image @@
# inference.llmkube.dev/v1alpha1/InferenceService/ai/qwen36-27b
! ± value change
- ghcr.io/tanguille/sglang-rdna4:v0.5.16-gfx1201@sha256:7ed88348a9ba70659a9a149c80e0b79d617f031011ec216b85372f7a56e261a6
+ ghcr.io/tanguille/sglang-rdna4:v0.5.16-gfx1201@sha256:615cb4265400f5468da4c32221f0086df075b126ce8dbfa78d998e844a5e424d
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@kubernetes/apps/ai/llmkube/models/qwen36-27b-sglang.yaml`:
- Line 80: Update SGLANG_HICACHE_FILE_BACKEND_STORAGE_DIR in the manifest to use
a new cache-directory suffix matching the changed image digest, rather than
/hicache/sglang-v0.5.16_awq-f541031d; ensure the old hi-cache cannot be reused.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: cfe4bef4-d9d5-4990-a0ca-4b23a4805778
📒 Files selected for processing (1)
kubernetes/apps/ai/llmkube/models/qwen36-27b-sglang.yaml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Tanguille/LLMKube(auto-detected)Tanguille/2x-R9700-RDNA4-GFX1201-sglang-inference(auto-detected)
| # Operator default binds :: (IPv6-only on this IPv4 cluster); override to v4. | ||
| bindAddress: 0.0.0.0 | ||
| image: ghcr.io/tanguille/sglang-rdna4:v0.5.16-gfx1201@sha256:7ed88348a9ba70659a9a149c80e0b79d617f031011ec216b85372f7a56e261a6 | ||
| image: ghcr.io/tanguille/sglang-rdna4:v0.5.16-gfx1201@sha256:615cb4265400f5468da4c32221f0086df075b126ce8dbfa78d998e844a5e424d |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Invalidate the hi-cache when changing the image digest.
The image digest changes here, but SGLANG_HICACHE_FILE_BACKEND_STORAGE_DIR remains /hicache/sglang-v0.5.16_awq-f541031d at Lines 124-127. The manifest explicitly says this suffix must change with the image digest; otherwise the new container may reuse stale KV pages. Update the suffix or explicitly invalidate the old cache in this change.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@kubernetes/apps/ai/llmkube/models/qwen36-27b-sglang.yaml` at line 80, Update
SGLANG_HICACHE_FILE_BACKEND_STORAGE_DIR in the manifest to use a new
cache-directory suffix matching the changed image digest, rather than
/hicache/sglang-v0.5.16_awq-f541031d; ensure the old hi-cache cannot be reused.
This PR contains the following updates:
7ed8834→615cb42Configuration
📅 Schedule: (in timezone Europe/Brussels)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.