feat(container): update toolhive (0.40.1 ➔ 0.41.0) - #4232
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughToolHive’s application and CRD OCI references are bumped from 0.40.1 to 0.41.0. The HelmRelease memory-limit comment is updated to describe the newer chart’s behavior and observed RSS. ChangesToolHive configuration update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
@@ spec.template.spec.containers.manager.env.TOOLHIVE_ENABLE_STORAGE_VERSION_MIGRATOR.value @@
# apps/v1/Deployment/ai/toolhive-operator
! ± value change
- false
+ true
@@ spec.template.spec.containers.manager.env.TOOLHIVE_RUNNER_IMAGE.value @@
# apps/v1/Deployment/ai/toolhive-operator
! ± value change
- ghcr.io/stacklok/toolhive/proxyrunner:v0.40.1
+ ghcr.io/stacklok/toolhive/proxyrunner:v0.41.0
@@ spec.template.spec.containers.manager.env.VMCP_IMAGE.value @@
# apps/v1/Deployment/ai/toolhive-operator
! ± value change
- ghcr.io/stacklok/toolhive/vmcp:v0.40.1
+ ghcr.io/stacklok/toolhive/vmcp:v0.41.0
@@ spec.template.spec.containers.manager.image @@
# apps/v1/Deployment/ai/toolhive-operator
! ± value change
- ghcr.io/stacklok/toolhive/operator:v0.40.1
+ ghcr.io/stacklok/toolhive/operator:v0.41.0
|
@@ spec.ref.tag @@
# source.toolkit.fluxcd.io/v1/OCIRepository/ai/toolhive-operator
! ± value change
- 0.40.1
+ 0.41.0
@@ spec.ref.tag @@
# source.toolkit.fluxcd.io/v1/OCIRepository/ai/toolhive-operator-crds
! ± value change
- 0.40.1
+ 0.41.0
|
AI Automated ReviewAnalysis engine: qwen-3.6-fast@http://litellm.ai.svc.cluster.local/v1 (openai) Recommendation: Approve This is a clean, minor version bump of the ToolHive operator and CRDs from Change-by-Change Findings
Release NotesSource: stacklok/toolhive v0.41.0 and v0.40.1
No explicit breaking changes or migration steps were identified in the upstream release notes for this range. The upgrade path appears safe for GitOps reconciliation. Standards Compliance
Unknowns or Needs Verification
|
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@kubernetes/apps/ai/toolhive/app/helmrelease.yaml`:
- Line 14: Update the comment in the HelmRelease to refer to 128Mi as the memory
request or baseline, not the default limit, while preserving the existing
explanation about live RSS and required headroom.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6f506375-9ddf-4012-9279-1ef49baf2615
📒 Files selected for processing (5)
kubernetes/apps/ai/toolhive/app/helmrelease.yamlkubernetes/apps/ai/toolhive/app/ocirepository.yamlkubernetes/apps/ai/toolhive/config/github.yamlkubernetes/apps/ai/toolhive/config/kustomization.yamlkubernetes/apps/ai/toolhive/crds/ocirepository.yaml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Tanguille/LLMKube(auto-detected)Tanguille/2x-R9700-RDNA4-GFX1201-sglang-inference(auto-detected)
💤 Files with no reviewable changes (1)
- kubernetes/apps/ai/toolhive/config/github.yaml
| values: | ||
| operator: | ||
| # Chart sets GOMEMLIMIT=150MiB; default limit 128Mi is lower → OOMKilled. Raise limit so runtime stays under cgroup. | ||
| # Chart lowered GOMEMLIMIT to 110MiB in 0.41.0, but live RSS sits at 128Mi — exactly the chart's default limit. Keep headroom. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== kubernetes/apps/ai/toolhive/app/helmrelease.yaml =="
cat -n kubernetes/apps/ai/toolhive/app/helmrelease.yaml | sed -n '1,120p'
echo
echo "== search for GOMEMLIMIT / memory settings =="
rg -n "GOMEMLIMIT|memory|request|limit|toolhive" kubernetes/apps/ai/toolhive -SRepository: Tanguille/cluster
Length of output: 24012
Use request/baseline instead of “default limit.”
This HelmRelease sets a 128Mi memory request and a 256Mi limit, so calling 128Mi the “default limit” is misleading. Rename it to request/baseline to avoid confusion.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@kubernetes/apps/ai/toolhive/app/helmrelease.yaml` at line 14, Update the
comment in the HelmRelease to refer to 128Mi as the memory request or baseline,
not the default limit, while preserving the existing explanation about live RSS
and required headroom.
Chart 0.41.0 lowers GOMEMLIMIT from 150MiB to 110MiB, so the old comment no longer describes why the limit deviates from the chart default. Live RSS sits at 128Mi, exactly the default, so the headroom stays.
749f889 to
cbee910
Compare
1 participant
This PR contains the following updates:
0.40.1→0.41.00.40.1→0.41.0Configuration
📅 Schedule: (in timezone Europe/Brussels)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.