-
-
Notifications
You must be signed in to change notification settings - Fork 454
feat(marko-virtual): add @tanstack/marko-virtual adapter for Marko v6 #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2fcb5ba
first set of changes
f5f8539
fix more breaking things
7e0343c
more fixes
34d5fb0
Fix examples
fa3e607
Fix more issues
3ca9e94
fix tests
6e0a456
fix everything
bc7f380
minor thingies
759c7b7
minor fixes
9bcc66f
more fixes
5a6d720
Fix some review comments
2a32067
Fix iframe in docs missing title
286156b
few more minor fixes and tests
9485946
ci: apply automated fixes
autofix-ci[bot] aa90c4e
fix(marko-virtual): address code review feedback and test coverage gaps
49b03ea
merge & resolve conflicts
052e9bf
Merge branch 'main' of github.com:TanStack/virtual
defunkt-dev 6cca898
merge & resolve conflicts after pull from upstream/main
defunkt-dev 42c1b18
fix: PR review comments
defunkt-dev 9114d54
Merge branch 'main' of github.com:TanStack/virtual
defunkt-dev 8fd285d
Fix the lock file
defunkt-dev ecf8034
Merge branch 'main' of github.com:TanStack/virtual
defunkt-dev 54f9629
Merge branch 'main' into main
piecyk 29f55c0
fix pr review comments
defunkt-dev 08b91cb
del files .md in examples
defunkt-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,8 +9,14 @@ | |
| { | ||
| "label": "Getting Started", | ||
| "children": [ | ||
| { "label": "Introduction", "to": "introduction" }, | ||
| { "label": "Installation", "to": "installation" } | ||
| { | ||
| "label": "Introduction", | ||
| "to": "introduction" | ||
| }, | ||
| { | ||
| "label": "Installation", | ||
| "to": "installation" | ||
| } | ||
| ], | ||
| "frameworks": [ | ||
| { | ||
|
|
@@ -34,7 +40,10 @@ | |
| { | ||
| "label": "solid", | ||
| "children": [ | ||
| { "label": "Solid Virtual", "to": "framework/solid/solid-virtual" } | ||
| { | ||
| "label": "Solid Virtual", | ||
| "to": "framework/solid/solid-virtual" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -54,14 +63,29 @@ | |
| "to": "framework/vue/vue-virtual" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "label": "marko", | ||
| "children": [ | ||
| { | ||
| "label": "Marko Virtual", | ||
| "to": "framework/marko/marko-virtual" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "label": "Core APIs", | ||
| "children": [ | ||
| { "label": "Virtualizer", "to": "api/virtualizer" }, | ||
| { "label": "VirtualItem", "to": "api/virtual-item" } | ||
| { | ||
| "label": "Virtualizer", | ||
| "to": "api/virtualizer" | ||
| }, | ||
| { | ||
| "label": "VirtualItem", | ||
| "to": "api/virtual-item" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -236,8 +260,41 @@ | |
| "label": "Dynamic" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "label": "marko", | ||
| "children": [ | ||
| { | ||
| "to": "framework/marko/examples/fixed", | ||
| "label": "Fixed" | ||
| }, | ||
| { | ||
| "to": "framework/marko/examples/variable", | ||
| "label": "Variable" | ||
| }, | ||
| { | ||
| "to": "framework/marko/examples/dynamic", | ||
| "label": "Dynamic" | ||
| }, | ||
| { | ||
| "to": "framework/marko/examples/grid", | ||
| "label": "Grid" | ||
| }, | ||
| { | ||
| "to": "framework/marko/examples/infinite-scroll", | ||
| "label": "Infinite Scroll" | ||
| }, | ||
| { | ||
| "to": "framework/marko/examples/smooth-scroll", | ||
| "label": "Smooth Scroll" | ||
| }, | ||
| { | ||
| "to": "framework/marko/examples/window", | ||
| "label": "Window" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's add new line
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes this is fixed now |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| title: Marko Dynamic Example | ||
| --- | ||
|
|
||
| ## Example | ||
|
|
||
| <iframe | ||
| src="https://stackblitz.com/github/TanStack/virtual/tree/main/examples/marko/dynamic?embed=1&theme=dark" | ||
| style="width:100%;height:500px;border:0;border-radius:4px;overflow:hidden" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | ||
| /> | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| title: Marko Fixed Example | ||
| --- | ||
|
|
||
| ## Example | ||
|
|
||
| <iframe | ||
| src="https://stackblitz.com/github/TanStack/virtual/tree/main/examples/marko/fixed?embed=1&theme=dark" | ||
| style="width:100%;height:500px;border:0;border-radius:4px;overflow:hidden" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | ||
| /> | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| title: Marko Grid Example | ||
| --- | ||
|
|
||
| ## Example | ||
|
|
||
| <iframe | ||
| src="https://stackblitz.com/github/TanStack/virtual/tree/main/examples/marko/grid?embed=1&theme=dark" | ||
| style="width:100%;height:500px;border:0;border-radius:4px;overflow:hidden" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | ||
| /> | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| title: Marko Infinite Scroll Example | ||
| --- | ||
|
|
||
| ## Example | ||
|
|
||
| <iframe | ||
| src="https://stackblitz.com/github/TanStack/virtual/tree/main/examples/marko/infinite-scroll?embed=1&theme=dark" | ||
| style="width:100%;height:500px;border:0;border-radius:4px;overflow:hidden" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | ||
| /> | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| title: Marko Smooth Scroll Example | ||
| --- | ||
|
|
||
| ## Example | ||
|
|
||
| <iframe | ||
| src="https://stackblitz.com/github/TanStack/virtual/tree/main/examples/marko/smooth-scroll?embed=1&theme=dark" | ||
| style="width:100%;height:500px;border:0;border-radius:4px;overflow:hidden" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | ||
| /> | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| title: Marko Variable Example | ||
| --- | ||
|
|
||
| ## Example | ||
|
|
||
| <iframe | ||
| src="https://stackblitz.com/github/TanStack/virtual/tree/main/examples/marko/variable?embed=1&theme=dark" | ||
| style="width:100%;height:500px;border:0;border-radius:4px;overflow:hidden" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | ||
| /> | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| title: Marko Window Example | ||
| --- | ||
|
|
||
| ## Example | ||
|
|
||
| <iframe | ||
| src="https://stackblitz.com/github/TanStack/virtual/tree/main/examples/marko/window?embed=1&theme=dark" | ||
| style="width:100%;height:500px;border:0;border-radius:4px;overflow:hidden" | ||
| sandbox="allow-forms allow-modals allow-popups allow-presentation allow-same-origin allow-scripts" | ||
| /> | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert those unrelated changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This is fixed.