Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): doc container width not taking up all available space #352

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

nikolovlazar
Copy link
Contributor

@nikolovlazar nikolovlazar commented Feb 22, 2025

I noticed on some pages the width of the page container wasn't taking up all the space. You can see this in production on the Classes/Effects page in Store. Here it is in dev locally:

CleanShot 2025-02-22 at 08 31 03@2x

Turns out the DocContainer.tsx file didn't specify its width, only its max width. Setting the width to full fixes the issue:

CleanShot 2025-02-22 at 08 31 24@2x

Copy link

netlify bot commented Feb 22, 2025

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit 9c2eb00
🔍 Latest deploy log https://app.netlify.com/sites/tanstack/deploys/67b9d2348213750008554b0d
😎 Deploy Preview https://deploy-preview-352--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 43 (🔴 down 15 from production)
Accessibility: 95 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 77 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SeanCassiere SeanCassiere merged commit e1caa92 into TanStack:main Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants