fix dynamic data updates in the Lit Table Adapter #5884
Merged
+375
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapter, updating a data array did not get reflected by the table. It is a one-line change to the TableController, and a new example that demonstrates the difference.
|
@kadoshms We've had problems in the Lit adapter with data not being reactive. This fixes it. Wonder if we need to make more/all table options reactive? Maybe at least columns too? |
|
I'm fairly sure making the columns reactive is a similar one line fix, but I didn't test that. I didn't need it. |
|
and many thanks to @KevinVandy for walking me through this. |
|
LGTM As suggested - this is true for columns as well, good catch 👍 |
kadoshms
reviewed
Jan 26, 2025
per suggestion from @kadoshms Co-authored-by: Mor Kadosh <[email protected]>
KevinVandy
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes an issue I discussed in discord where with the lit table
adapter, updating a data array did not get reflected by the table.
It is a one-line change to the TableController, and a new example that demonstrates the difference.