refactor(store): improve __flush_internals performance by pre-sorting derived deps #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming
Derived
stores are more often updated than created/destroyed, it should be more performant to pre-compute the deps order fromregisterOnGraph
when we add them to__storeToDerived
, than to re-sort every time we call__flush_internals
benchmark (tl;dr 3.7x)
For completeness, because this PR makes creating a
Derived
store more expensive than before, we can also do a benchmark of that to assess the damage (tl;dr 1.05x slower). The measured slowdown here seems consistent, but the effect size is so small it could virtually be ignored.