Skip to content

fix(router-core): preserve retained beforeLoad context while pending - #8067

Closed
ulrichstark wants to merge 2 commits into
TanStack:mainfrom
ulrichstark:fix(router-core)--preserve-retained-beforeLoad-context-while-pending
Closed

ulrichstark wants to merge 2 commits into
TanStack:mainfrom
ulrichstark:fix(router-core)--preserve-retained-beforeLoad-context-while-pending

apply coderabbit suggestion

59ff021
Select commit
Loading
Failed to load commit list.
CodSpeed / CodSpeed Performance Analysis failed Aug 14, 2026 in 0s

Performance Regression: -21.55%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 10 regressed benchmarks
✅ 166 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Memory mem server server-fn-churn (vue) 359.7 KB 4,601.4 KB -92.18%
❌ Memory mem server peak-large-page (react) 1.2 MB 2 MB -42.19%
❌ Memory mem client unique-location-churn (vue) 498.4 KB 601.8 KB -17.17%
❌ Memory mem server error-paths not-found (solid) 901.9 KB 1,040.7 KB -13.34%
❌ Simulation client-nested-params navigation loop (react) 213.7 ms 228.7 ms -6.57%
❌ Simulation ssr dehydrate rich types (solid) 307.8 ms 325.5 ms -5.44%
❌ Memory mem server error-paths unmatched (solid) 559 KB 586.6 KB -4.7%
❌ Memory mem server aborted-requests (react) 868.7 KB 905.3 KB -4.04%
❌ Simulation ssr dehydrate plain control (solid) 410.8 ms 425.1 ms -3.36%
❌ Memory mem server error-paths unmatched (vue) 582 KB 600.6 KB -3.09%
⚡ Memory mem server error-paths unmatched (react) 479.8 KB 426.6 KB +12.48%
⚡ Memory mem client navigation-churn (solid) 731.7 KB 669.3 KB +9.33%
⚡ Memory mem server peak-large-page (vue) 1.1 MB 1 MB +6.46%
⚡ Memory mem server request-churn (react) 687.2 KB 659.8 KB +4.14%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ulrichstark:fix(router-core)--preserve-retained-beforeLoad-context-while-pending (59ff021) with main (0c25a7b)

Open in CodSpeed