Skip to content

don't use esbuild to minify in vite's bundlesize benchmarks - #7995

Merged
schiller-manuel merged 1 commit into
mainfrom
bundlesize-no-esbuild
Aug 8, 2026
Merged

don't use esbuild to minify in vite's bundlesize benchmarks#7995
schiller-manuel merged 1 commit into
mainfrom
bundlesize-no-esbuild

Conversation

@schiller-manuel

@schiller-manuel schiller-manuel commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor
    • Updated the Vite benchmark build configuration to use its default JavaScript target and minification settings.

@schiller-manuel
schiller-manuel requested a review from a team as a code owner August 7, 2026 23:21
@nx-cloud

nx-cloud Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit feb9739

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 25s View ↗
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-08 00:00:17 UTC

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 49f333b2-334e-43fb-896f-b638acc85ee7

📥 Commits

Reviewing files that changed from the base of the PR and between 2265129 and 131278f.

📒 Files selected for processing (1)
  • scripts/benchmarks/bundle-size/measure.mjs
💤 Files with no reviewable changes (1)
  • scripts/benchmarks/bundle-size/measure.mjs

📝 Walkthrough

Walkthrough

The Vite scenario build removes explicit ES2022 targeting and esbuild minification. Sourcemap generation, compressed-size reporting, and manifest settings remain unchanged.

Changes

Bundle-size benchmark build

Layer / File(s) Summary
Vite build settings
scripts/benchmarks/bundle-size/measure.mjs
The build no longer forces ES2022 or esbuild minification. Existing sourcemap, compressed-size, and manifest settings remain.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: disabling esbuild minification in Vite bundle-size benchmarks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bundlesize-no-esbuild

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 7, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7995

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7995

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7995

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7995

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7995

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7995

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7995

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7995

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7995

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7995

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7995

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7995

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7995

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7995

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7995

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7995

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7995

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7995

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7995

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7995

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7995

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7995

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7995

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7995

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7995

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7995

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7995

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7995

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7995

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7995

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7995

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7995

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7995

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7995

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7995

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7995

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7995

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7995

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7995

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7995

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7995

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7995

commit: feb9739

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: e03aae62d5da
  • Measured at: 2026-08-07T23:58:20.731Z
  • Baseline source: history:2265129b4023
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 83.91 KiB -3.08 KiB (-3.54%) 83.77 KiB 262.61 KiB 72.93 KiB ███████████▁
react-router.full 87.40 KiB -3.36 KiB (-3.70%) 87.26 KiB 274.33 KiB 76.14 KiB ███████████▁
solid-router.minimal 33.22 KiB -1.43 KiB (-4.13%) 33.09 KiB 96.45 KiB 29.93 KiB ██▇▇▇▇▇▇▇▇▇▁
solid-router.full 38.05 KiB -1.66 KiB (-4.18%) 37.92 KiB 111.09 KiB 34.22 KiB ██▇▇▇▇▇▇▇▇▇▁
vue-router.minimal 49.50 KiB -2.38 KiB (-4.59%) 49.37 KiB 138.20 KiB 44.61 KiB ██▇▇▇▇▇▇▇▇▇▁
vue-router.full 55.07 KiB -2.72 KiB (-4.71%) 54.95 KiB 156.37 KiB 49.57 KiB ██▇▇▇▇▇▇▇▇▇▁
react-start.minimal 96.66 KiB -3.71 KiB (-3.70%) 96.53 KiB 304.79 KiB 83.72 KiB ███████████▁
react-start.deferred-hydration 97.39 KiB -3.72 KiB (-3.68%) 96.55 KiB 306.15 KiB 84.36 KiB ███████████▁
react-start.full 99.83 KiB -3.92 KiB (-3.78%) 99.70 KiB 314.50 KiB 86.53 KiB ███████████▁
solid-start.minimal 45.94 KiB -2.02 KiB (-4.20%) 45.81 KiB 137.46 KiB 40.89 KiB ██▇▇▇▇▇▇▇▇▇▁
solid-start.deferred-hydration 49.00 KiB -2.16 KiB (-4.23%) 45.87 KiB 144.92 KiB 43.71 KiB ██▇▇▇▇▇▇▇▇▇▁
solid-start.full 51.02 KiB -2.21 KiB (-4.16%) 50.89 KiB 152.84 KiB 45.17 KiB ██▇▇▇▇▇▇▇▇▇▁
vue-start.minimal 65.49 KiB -3.15 KiB (-4.59%) 65.36 KiB 188.97 KiB 58.34 KiB ██▇▇▇▇▇▇▇▇▇▁
vue-start.full 69.28 KiB -3.36 KiB (-4.63%) 69.16 KiB 201.24 KiB 61.56 KiB ██▇▇▇▇▇▇▇▇▇▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@schiller-manuel
schiller-manuel merged commit 4fa1df7 into main Aug 8, 2026
13 checks passed
@schiller-manuel
schiller-manuel deleted the bundlesize-no-esbuild branch August 8, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants