Skip to content

fix(start-server-core): update to h3 v2.0.1-rc.2 #6159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birkskyum merged 3 commits into from
Dec 20, 2025
Merged

fix(start-server-core): update to h3 v2.0.1-rc.2 #6159

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba2b4a0
use h3.internal.event.res
birkskyum Dec 19, 2025
37e52af
ci: apply automated fixes
autofix-ci[bot] Dec 20, 2025
7002b29
2.0.1-rc.2
birkskyum Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/start-server-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"@tanstack/router-core": "workspace:*",
"@tanstack/start-client-core": "workspace:*",
"@tanstack/start-storage-context": "workspace:*",
"h3-v2": "npm:h3@2.0.0-beta.5",
"h3-v2": "npm:h3@2.0.1-rc.6",

@coderabbitai coderabbitai Bot Dec 20, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

find . -type f -name "*request-response*" -o -name "*response*" | grep -E "\.(ts|js)$" | head -20

Repository: TanStack/router

Length of output: 111

🏁 Script executed:

cat ./packages/start-server-core/src/request-response.ts

Repository: TanStack/router

Length of output: 9267

H3 v2.0.1-rc.6 exists, but code relies on undocumented internal Symbol API that could break during pre-release stages.

H3 v2.0.1-rc.6 is available, and while H3 v2 documents internal Symbols like Symbol.for("h3.notFound") and Symbol.for("h3.handled"), the specific Symbol.for('h3.internal.event.res') used in getResponse() is not documented in the official H3 v2 guide. The @ts-expect-error comment in the code acknowledges this reliance on internal APIs.

Since h3 v2.0.1-rc.6 is still in release candidate stage, undocumented internal Symbols could change or break between RC versions or during the final stable release. Consider either waiting for a stable h3 v2.0.0 release, using a documented H3 API alternative for response access, or pinning to a specific RC version with awareness of potential instability.

"seroval": "^1.4.1",
"tiny-invariant": "^1.3.3"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/start-server-core/src/request-response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ export function clearSession(config: Partial<SessionConfig>): Promise<void> {
// not public API
export function getResponse() {
const event = getH3Event()
return event._res
// @ts-expect-error accessing internal symbol
return event[Symbol.for('h3.internal.event.res')]
}

// not public API (yet)
Expand Down
31 changes: 17 additions & 14 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading