Skip to content

test(router): wait for nav to complete #5744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2025
Merged

test(router): wait for nav to complete #5744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
778a850
test(router): wait for nav to complete
birkskyum Nov 3, 2025
97bfa9c
ci: apply automated fixes
autofix-ci[bot] Nov 3, 2025
b418728
cleanup preload
birkskyum Nov 3, 2025
17be63c
cleanup
birkskyum Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/react-router/tests/link.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,11 @@ describe('Link', () => {

await act(() => fireEvent.click(updateSearchLink))

// Wait for navigation to complete and search params to update
await waitFor(() => {
expect(window.location.search).toBe('?page=2&filter=inactive')
})

// Verify search was updated
expect(window.location.pathname).toBe('/posts')
expect(window.location.search).toBe('?page=2&filter=inactive')
Expand Down Expand Up @@ -860,6 +865,11 @@ describe('Link', () => {

await act(() => fireEvent.click(updateSearchLink))

// Wait for navigation to complete and search params to update
await waitFor(() => {
expect(window.location.search).toBe('?page=2&filter=inactive')
})

// Verify search was updated
expect(window.location.pathname).toBe('/Dashboard/posts')
expect(window.location.search).toBe('?page=2&filter=inactive')
Expand Down
14 changes: 12 additions & 2 deletions packages/solid-router/tests/link.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,12 @@ describe('Link', () => {
'/posts?page=2&filter=inactive',
)

fireEvent.click(updateSearchLink)
await fireEvent.click(updateSearchLink)

// Wait for navigation to complete and search params to update
await waitFor(() => {
expect(window.location.search).toBe('?page=2&filter=inactive')
})

const updatedPage = await screen.findByTestId('current-page')
const updatedFilter = await screen.findByTestId('current-filter')
Expand Down Expand Up @@ -888,7 +893,12 @@ describe('Link', () => {
'/Dashboard/posts?page=2&filter=inactive',
)

fireEvent.click(updateSearchLink)
await fireEvent.click(updateSearchLink)

// Wait for navigation to complete and search params to update
await waitFor(() => {
expect(window.location.search).toBe('?page=2&filter=inactive')
})

await screen.findByTestId('current-page')
// Verify search was updated
Expand Down
Loading