fix: Add optimizeDeps.entries for client and ssr environments
#5223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughAdds a router alias and simplifies entry-alias resolution in start-plugin-core, changes internal ENTRY_POINTS identifiers, adds tinyglobby as a dependency, and updates default entry file names and a comment in React/Solid Vite plugins; optimizeDeps lists now include escaped alias entries. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant Plugin as start-plugin-core
participant Const as ENTRY_POINTS
participant Escape as tinyglobby.escapePath
participant Vite as Vite Config
Dev->>Plugin: initialize plugin (client/server/start/router paths)
Plugin->>Const: read ENTRY_POINTS placeholders
Plugin->>Plugin: compute aliases (clientAlias, serverAlias, startAlias, routerAlias) using ?? defaults
Plugin->>Escape: escape alias entries for optimizeDeps.include
Escape-->>Plugin: escaped paths
Plugin->>Vite: inject alias map (client/server/start/router)
Plugin->>Vite: add optimizeDeps.include for client and server using escaped aliases
Vite-->>Dev: final Vite config with aliases and optimizeDeps
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
|
View your CI Pipeline Execution ↗ for commit 9e29f18
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/start-plugin-core/src/plugin.ts (1)
136-146: Alias computation/readability looks goodThe nullish-coalescing defaults with normalizePath are clear and correct. The router alias introduction aligns with the new strategy.
Optional: factor a tiny helper to reduce repetition:
const normWithDefault = (p: string | undefined, d: string) => vite.normalizePath(p ?? d) const clientAlias = normWithDefault(clientEntryPath, corePluginOpts.defaultEntryPaths.client) const serverAlias = normWithDefault(serverEntryPath, corePluginOpts.defaultEntryPaths.server) const startAlias = normWithDefault(startFilePath, corePluginOpts.defaultEntryPaths.start)Also applies to: 153-155
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/react-start/src/plugin/vite.ts(1 hunks)packages/start-plugin-core/src/plugin.ts(3 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript in strict mode with extensive type safety across the codebase
Files:
packages/react-start/src/plugin/vite.tspackages/start-plugin-core/src/plugin.ts
packages/{*-start,start-*}/**
📄 CodeRabbit inference engine (AGENTS.md)
Name and place Start framework packages under packages/-start/ or packages/start-/
Files:
packages/react-start/src/plugin/vite.tspackages/start-plugin-core/src/plugin.ts
🧠 Learnings (1)
📚 Learning: 2025-09-23T17:36:12.598Z
Learnt from: CR
PR: TanStack/router#0
File: AGENTS.md:0-0
Timestamp: 2025-09-23T17:36:12.598Z
Learning: Applies to packages/{react-router,solid-router}/** : Implement React and Solid bindings/components only in packages/react-router/ and packages/solid-router/
Applied to files:
packages/react-start/src/plugin/vite.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (1)
packages/react-start/src/plugin/vite.ts (1)
68-68: LGTM — comment tweak onlyNon-behavioral change. Safe.
jamesopstad
force-pushed
the
optimize-deps-entries
branch
from
604c720 to
92ce7fe
Compare
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/nitro-v2-vite-plugin
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-ssr-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-ssr-query-core
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-static-server-functions
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
schiller-manuel
changed the title
optimizeDeps.entries for client and ssr environmentsoptimizeDeps.entries for client and ssr environments
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
optimizeDeps.entriesfor theclientandssrenvironments so that dependencies are discovered when starting the dev server.Summary by CodeRabbit