fix: remove solid-js dependency from react-router-devtools - #4376
Conversation
|
View your CI Pipeline Execution ↗ for commit d9f7b1f.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
|
I'm not using solid js and got the same error with |
|
Do we need to revert this? @luixo |
|
Maybe just move the solid-js dep to be an normal dependency instead an development? |
|
On a completely fresh project using Yarn, the project fails to start because solid-js isn’t installed. With NPM, which installs peer dependencies, this problem doesn’t occur. |
We don't need to depend on solid-js to import JSX types in react-router-devtools package