Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start): use user's ssr.noExternal config #2665

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

ValeraS
Copy link
Contributor

@ValeraS ValeraS commented Oct 28, 2024

Closes #2663

Copy link

nx-cloud bot commented Oct 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 757201d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 28, 2024

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2665

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2665

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2665

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2665

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2665

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2665

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2665

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2665

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2665

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2665

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2665

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2665

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2665

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2665

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2665

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2665

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2665

commit: 757201d

@schiller-manuel schiller-manuel merged commit 4079472 into TanStack:main Oct 28, 2024
5 checks passed
@schiller-manuel
Copy link
Contributor

thanks a lot for your contribution!

@ValeraS ValeraS deleted the issue-2663 branch October 28, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@tanstack/start ignores vite.ssr.noExternal from app.config
2 participants