Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle route groups #2550

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix: correctly handle route groups #2550

merged 2 commits into from
Oct 15, 2024

Conversation

schiller-manuel
Copy link
Contributor

do not remove route groups from ids as we need them to ensure uniqueness of ids at runtime.

fixes #2501

Copy link

nx-cloud bot commented Oct 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cfccf1a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 15, 2024

Open in Stackblitz

More templates

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2550

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2550

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2550

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2550

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2550

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2550

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2550

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2550

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2550

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2550

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2550

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2550

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2550

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2550

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2550

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2550

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2550

commit: cfccf1a

do not remove route groups from ids as we need them to ensure uniqueness of ids at runtime.

fixes #2501
@schiller-manuel schiller-manuel merged commit 8c7f14b into main Oct 15, 2024
5 checks passed
@schiller-manuel schiller-manuel deleted the fix-2501 branch October 15, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match Error with useSearch inside a route nested in a layout and pathless route group
1 participant