fix: rollup umd output name #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HugoBDev is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
|
View your CI Pipeline Execution ↗ for commit 6790f7f.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #780ae4, rollup started outputting the UMD bundle as
/build/umd/index.production.jsinstead of/build/umd/index.production.min.js. This breaks build tools (Vite, Parcel, etc.) that use thebrowservalue from each packagespackage.json.I figured the correct output would be
/build/umd/index.production.min.js, but we might want to update each package'sbrowservalue instead to point to the new/build/umd/index.production.js.I was going through this issue in a project using Parcel v2. I tested this change by applying this change, running
yarn run buildandyarn run linkAll, and linking the libraries locally. My test project did use all packages, onlyreact-locationandreact-location-jsurl.Fixes #220
Fixes #216