-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-router,start): ensure document is only used when available #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lo1tuma
force-pushed
the
check-document
branch
3 times, most recently
from
August 12, 2024 15:14
9921b26
to
3ab6098
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3da769a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
SeanCassiere
requested changes
Aug 19, 2024
lo1tuma
force-pushed
the
check-document
branch
from
August 19, 2024 07:41
3ab6098
to
8b74e9d
Compare
@SeanCassiere thanks for the review. I’ve addressed all comments so far. |
SeanCassiere
requested changes
Aug 19, 2024
SeanCassiere
approved these changes
Aug 19, 2024
This was referenced Sep 9, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m trying to use
react-test-renderer
to render a component that uses router hooks or components likeMeta
. It seems likereact-test-renderer
is always executinguseLayoutEffect
anduseEffect
. Since I don’t have a globalwindow
ordocument
object during my test run, some components fail when usingdocument
without checking if it exist.See also discussion #2109.