Skip to content

fix(eslint-plugin-query): add footer workaround for CJS default export in modernConfig #8991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

fix(eslint-plugin-query): add footer workaround for CJS default export in modernConfig #8991

merged 1 commit into from
Apr 11, 2025

Conversation

@Newbie012
Copy link
Collaborator

@Newbie012 Newbie012 commented Apr 10, 2025

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Apr 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ed699b1.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 23s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-10 18:21:01 UTC

@Newbie012 Newbie012 requested a review from Copilot April 10, 2025 18:16
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • examples/react/eslint-legacy/.eslintrc: Language not supported
  • examples/react/eslint-legacy/package.json: Language not supported
  • examples/react/eslint-legacy/tsconfig.json: Language not supported
  • pnpm-lock.yaml: Language not supported

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 10, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8991

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8991

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8991

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8991

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8991

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8991

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8991

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8991

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8991

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8991

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8991

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8991

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8991

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8991

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8991

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8991

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8991

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8991

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8991

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8991

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8991

commit: ed699b1

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

Sizes for commit ed699b1:

Branch Bundle Size
Main
This PR

@Newbie012 Newbie012 mentioned this pull request Apr 10, 2025
Closed
@codecov
Copy link

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.55%. Comparing base (2e1282c) to head (ed699b1).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8991   +/-   ##
=======================================
  Coverage   44.55%   44.55%           
=======================================
  Files         202      202           
  Lines        8067     8067           
  Branches     1784     1786    +2     
=======================================
  Hits         3594     3594           
  Misses       4049     4049           
  Partials      424      424
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.08% <ø> (ø)
@tanstack/eslint-plugin-query 88.19% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 94.77% <ø> (ø)
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit f536199 into main Apr 11, 2025
7 checks passed
@TkDodo TkDodo deleted the fix-ensure-proper-esling-modern-cjs-build branch April 11, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

package: eslint-plugin-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Newbie012 @TkDodo